fix: federation upstream set (ci error)

[sylvainfaivre]

PR progress checklist (to be filled in by reviewers)

• Changes to documentation are appropriate (or tick if not required)
• Changes to tests are appropriate (or tick if not required)
• Reviews completed

---

What type of PR is this?

• [fix] A bug fix

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

This fixes 2 errors in the CI vms, and probably in regular use too, regarding federation setup :

first error :

       ----------
                 ID: rabbitmq-config-parameters-present-rabbit-my-federation-upstream-set
           Function: cmd.run
               Name: /usr/sbin/rabbitmqctl --node rabbit set_parameter --vhost=default_vhost federation-upstream-set 'my-federation-upstream-set' '[{"upstream": "my-federation-upstream1"},]'  # noqa 204
             Result: False
            Comment: Command "/usr/sbin/rabbitmqctl --node rabbit set_parameter --vhost=default_vhost federation-upstream-set 'my-federation-upstream-set' '[{"upstream": "my-federation-upstream1"},]'  # noqa 204" run
            Started: 15:54:19.151211
           Duration: 466.897 ms
            Changes:   
              ----------
              pid:
                  7865
              retcode:
                  69
              stderr:
                  warning: the VM is running with native name encoding of latin1 which may cause Elixir to malfunction as it expects utf8. Please ensure your locale is set to UTF-8 (which can be verified by running "locale" in your shell) or set the ELIXIR_ERL_OPTIONS="+fnu" environment variable
                  Error:
                  Could not parse JSON document: {error,
                                                     {failed_to_decode_json,
                                                         <<"[{\"upstream\": \"my-federation-upstream1\"},]">>}}
              stdout:
                  Setting runtime parameter "my-federation-upstream-set" for component "federation-upstream-set" to "[{"upstream": "my-federation-upstream1"},]" in vhost "default_vhost" ...

second error :

       ----------
                 ID: rabbitmq-config-parameters-present-rabbit2-my-federation-upstream-set
           Function: cmd.run
               Name: /usr/sbin/rabbitmqctl --node rabbit2 set_parameter --vhost=rabbit2_vhost federation-upstream-set 'my-federation-upstream-set' '[{"upstream": "my-federation-upstream1"},]'  # noqa 204
             Result: False
            Comment: Command "/usr/sbin/rabbitmqctl --node rabbit2 set_parameter --vhost=rabbit2_vhost federation-upstream-set 'my-federation-upstream-set' '[{"upstream": "my-federation-upstream1"},]'  # noqa 204" run
            Started: 15:54:20.079375
           Duration: 457.14 ms
            Changes:   
              ----------
              pid:
                  7981
              retcode:
                  69
              stderr:
                  warning: the VM is running with native name encoding of latin1 which may cause Elixir to malfunction as it expects utf8. Please ensure your locale is set to UTF-8 (which can be verified by running "locale" in your shell) or set the ELIXIR_ERL_OPTIONS="+fnu" environment variable
                  Error:
                  Could not parse JSON document: {error,
                                                     {failed_to_decode_json,
                                                         <<"[{\"upstream\": \"my-federation-upstream1\"},]">>}}
              stdout:
                  Setting runtime parameter "my-federation-upstream-set" for component "federation-upstream-set" to "[{"upstream": "my-federation-upstream1"},]" in vhost "rabbit2_vhost" ...

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

• Updated the README (e.g. Available states).
• Updated pillar.example.

Testing checklist

• Included in Kitchen (i.e. under state_top).
• Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
• Updated the relevant test pillar.

Additional context

[sylvainfaivre]

closing in favor of #129