Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dkim): add state to manage DKIM keys #8

Merged
merged 1 commit into from
May 15, 2021

Conversation

javierbertoli
Copy link
Member

PR progress checklist (to be filled in by reviewers)

  • Changes to documentation are appropriate (or tick if not required)
  • Changes to tests are appropriate (or tick if not required)
  • Reviews completed

What type of PR is this?

Primary type

  • [build] Changes related to the build system
  • [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
  • [ci] Changes to the continuous integration configuration
  • [feat] A new feature
  • [fix] A bug fix
  • [perf] A code change that improves performance
  • [refactor] A code change that neither fixes a bug nor adds a feature
  • [revert] A change used to revert a previous commit
  • [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

  • [docs] Documentation changes
  • [test] Adding missing or correcting existing tests

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

Added a new state to allow managing the DKIM keys with rspamd (using rspamadm dkim_keygen).

Modified the config state so keys added through this state are automatically added to rspamd's
configuration and the domain dict is merged as required.

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

  • Updated the README (e.g. Available states).
  • Updated pillar.example.

Testing checklist

  • Included in Kitchen (i.e. under state_top).
  • Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
  • Updated the relevant test pillar.

Additional context

@javierbertoli javierbertoli added documentation Formula's documentation (docs, pillar.example, etc.) enhancement New feature or request labels May 4, 2021
@javierbertoli javierbertoli force-pushed the master branch 4 times, most recently from 381899d to 024bde5 Compare May 4, 2021 22:02
@javierbertoli javierbertoli merged commit 0ea2459 into saltstack-formulas:master May 15, 2021
@javierbertoli
Copy link
Member Author

Self-merged

@saltstack-formulas-travis

🎉 This PR is included in version 0.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Formula's documentation (docs, pillar.example, etc.) enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants