Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow nesting commands under minion names in master ACL config #209

Closed

Conversation

johnccfm
Copy link

The current code allows ACL's like:-

client_acl:
  # Allow thatch to execute anything.
  thatch:
    - .*

But it breaks horribly on ACL's like:-

client_acl:
  # Allow fred to use test and pkg, but only on "web*" minions.
  fred:
    - web*:
      - test.*
      - pkg.*

This patch fixes this - perhaps not in the safest or most elegant way, but it seems to work.

@gravyboat
Copy link
Contributor

I'm going to need some secondary opinions on this, @BABILEN, @iggy, concerns over this? It's definitely a problem for backwards compatibility but other than that I like the functionality it adds.

@aboe76
Copy link
Member

aboe76 commented Jan 22, 2017

this should be rebased with this issue statement:
#275

@aboe76
Copy link
Member

aboe76 commented May 12, 2017

fixed in:
#301

@aboe76 aboe76 closed this May 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants