chore(libsaltcli): add lib to check type of Salt command being used
#131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 tasks
myii
added a commit
to myii/libvirt-formula
that referenced
this pull request
Mar 25, 2020
19 tasks
* To distinguish between:
- `salt-minion`
- `salt-call`
- `salt-ssh`
* Invoked like `map.jinja`:
- `{%- from tplroot ~ "/libsaltcli.jinja" import cli with context %}`
* Based upon work done in PRs: saltstack-formulas#102, saltstack-formulas#114 & saltstack-formulas#115
* Finalised from saltstack-formulas/libvirt-formula#71
* Required by saltstack-formulas#186
myii
force-pushed
the
chore/introduce-libsaltcli
branch
from
7721eb0
to
a6487b5
Compare
baby-gnu
approved these changes
Mar 25, 2020
|
🎉 This PR is included in version 4.0.6 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
@myii Thanks for this! |
|
@alxwr You're welcome. Be aware that we've already improved this library since including it (check the latest version in this formula). As a side note, a Formulas Working Group has started up, we had our first meeting two weeks ago. It's available on YouTube, see the contributors' team discussion for the link. Our next meeting is on Tuesday, it would be nice to catch up with you there if you can make it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
salt-minionsalt-callsalt-sshmap.jinja:{%- from tplroot ~ "/libsaltcli.jinja" import cli with context %}map.jinja): use pillar/config.getaccording to__clioption #102, map.jinja: use tplroot #114 & fix(map.jinja): _merge_ defaults andconfig.get#115