fix(libtofs): avoid using subpath by default

[myii]

So there are two TOFS improvements here in two commits.

For the first one:

• Only the systemd-formula uses these, so avoid for all other formulas
  • So need to merge this before propagating feat(tofs): update from latest template-formula version myii/ssf-formula#3

The second commit (refactor(libtofs): remove deprecated v1_path_prefix argument):

• Unused throughout all SaltStack Formulas
  • Effectively superseded by using subpath
  • May as well merge this and have this propagated by feat(tofs): update from latest template-formula version myii/ssf-formula#3 as well

[myii]

@baby-gnu So this is the fix alluded to in myii/ssf-formula#3 (comment).

[myii]

Need #157 merged first and then this will be rebased on top.

[myii]

Need #157 merged first and then this will be rebased on top.

Done, tests passing and this is ready for review and merge again.

[aboe76]

nice and clean solution @myii

[baby-gnu]

The lookup policy is driven by the formula writer.

As I saw the different changes done to give power to users wanting thing I did not think about, do you think that it can be useful to allow user to override the policy of the formula writer by setting a config like tofs.use_subpath.<lookup key>.

In which case you could add to files_switch something like:

  {#- Does user override subpath lookup? #}
  {%- set use_subpath = salt['config.get'](
      tplroot ~ ':tofs:use_subpath:' ~ lookup,
      use_subpath
  ) %}

This can be done later without breaking API, so just merge this for now and let users surprise us with their unthinkable use cases ;-)

[myii]

This can be done later without breaking API, so just merge this for now and let users surprise us with their unthinkable use cases ;-)

@baby-gnu Maybe it's actually the two of us, surprising users with our unthinkable use-cases! But seriously, I think TOFS has improved significantly from where it started, so thank you for your contributions and reviews. We can definitely revisit these extensions in upcoming discussions.

Thanks for putting up with us, @aboe76! Appreciate the reviews and support along the way.

[aboe76]

@myii no problem supporting this, I think you and the others are moving the formulas further and made them better, with tofs, semantic versioning, changelogs and travis testing.

[myii]

@aboe76 Thanks for that. Do you mind merging this? I'd like to update myii/ssf-formula#3 and then push out those PRs.

[saltstack-formulas-travis]

🎉 This PR is included in version 3.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀