Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(osfamilmap.yaml): dbus pkg name is not specific enough on Gentoo #24

Conversation

mgomersbach
Copy link

Signed-off-by: Mark Gomersbach markgomersbach@gmail.com

PR progress checklist (to be filled in by reviewers)

  • Changes to documentation are appropriate (or tick if not required)
  • Changes to tests are appropriate (or tick if not required)
  • Reviews completed

What type of PR is this?

Fix for package name of Gentoo

Primary type

  • [build] Changes related to the build system
  • [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
  • [ci] Changes to the continuous integration configuration
  • [feat] A new feature
  • [fix] A bug fix
  • [perf] A code change that improves performance
  • [refactor] A code change that neither fixes a bug nor adds a feature
  • [revert] A change used to revert a previous commit
  • [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

  • [docs] Documentation changes
  • [test] Adding missing or correcting existing tests

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

----------
          ID: dbus_for_timezone
    Function: pkg.installed
        Name: dbus
      Result: False
     Comment: Package 'dbus' not found (possible matches: sys-apps/dbus, dev-haskell/dbus)
     Started: 09:59:55.834177
    Duration: 20469.344 ms
     Changes:   

Documentation checklist

  • Updated the README (e.g. Available states).
  • Updated pillar.example.

Testing checklist

  • Included in Kitchen (i.e. under state_top).
  • Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
  • Updated the relevant test pillar.

Additional context

Signed-off-by: Mark Gomersbach <markgomersbach@gmail.com>
@myii
Copy link
Member

myii commented Mar 27, 2020

@mgomersbach Thanks for this. If we could produce a pre-salted image for Gentoo, we could add it to the matrix for testing across the relevant formulas. So referring back to:

I'll merge this as soon as the tests complete.

@myii myii merged commit 26bf1ff into saltstack-formulas:master Mar 27, 2020
@saltstack-formulas-travis

🎉 This PR is included in version 0.4.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@mgomersbach
Copy link
Author

Fair enough, I really need for myself too.

@myii
Copy link
Member

myii commented Mar 27, 2020

@mgomersbach Great, I forgot to link to the existing PR which is a work in progress:

Ignore that if it isn't useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants