ci: merge travis matrix, add salt-lint & rubocop to lint job
#212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myii
force-pushed
the
ci/merge-matrix-and-add-salt-lint-and-rubocop
branch
5 times, most recently
from
587e434 to
284ac78
Compare
```bash
Examining users/googleauth.sls of type state
[201] Trailing whitespace
users/googleauth.sls:9
- file: {{ users.googleauth_dir }}
[204] Lines should be no longer that 160 chars
users/googleauth.sls:26
- repl: "auth [success=done new_authtok_reqd=done default=die] pam_google_authenticator.so user=root secret={{ users.googleauth_dir }}/${USER}_{{ svc }} echo_verification_code\n@include common-auth"
```
```bash
Examining users/init.sls of type state
[206] Jinja variables should have spaces before and after: {{ var_name }}
users/init.sls:176
- expire: {{ (user['expire'] / 86400) | int}}
[206] Jinja variables should have spaces before and after: {{ var_name }}
users/init.sls:202
- {{optional_group}}
```
```bash
Examining users/sudo.sls of type state
[201] Trailing whitespace
users/sudo.sls:13
- file: {{ users.sudoers_dir }}
[201] Trailing whitespace
users/sudo.sls:22
- name: {{ users.sudoers_file }}
```
* Semi-automated using myii/ssf-formula#60
myii
force-pushed
the
ci/merge-matrix-and-add-salt-lint-and-rubocop
branch
from
284ac78 to
f17d156
Compare
|
🎉 This PR is included in version 0.48.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
salt-lint&rubocoptolintjob myii/ssf-formula#60