Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(proxy_conf): Reworked jinja Template for Zabbix Proxy 5.0 LTS #165

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

xenadmin
Copy link
Contributor

PR progress checklist (to be filled in by reviewers)

  • Changes to documentation are appropriate (or tick if not required)
  • Changes to tests are appropriate (or tick if not required)
  • Reviews completed

What type of PR is this?

Primary type

  • [build] Changes related to the build system
  • [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
  • [ci] Changes to the continuous integration configuration
  • [feat] A new feature
  • [fix] A bug fix
  • [perf] A code change that improves performance
  • [refactor] A code change that neither fixes a bug nor adds a feature
  • [revert] A change used to revert a previous commit
  • [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

  • [docs] Documentation changes
  • [test] Adding missing or correcting existing tests

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

Describe the changes you're proposing

Reworked jinja Template for Zabbix Proxy 5.0 LTS

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

  • Updated the README (e.g. Available states).
  • Updated pillar.example.

Testing checklist

  • Included in Kitchen (i.e. under state_top).
  • Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
  • Updated the relevant test pillar.

Additional context

Copy link
Collaborator

@hatifnatt hatifnatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xenadmin
Copy link
Contributor Author

xenadmin commented Aug 31, 2023

Please update commit message according with formulas guidelines

I've read that, and I have no idea that I need to change, sorry. Can you please give me a hint what exactly is missing?

Ps.: I think I got it now, please let me know if this is now as required!

@xenadmin xenadmin changed the title Reworked jinja Template for Zabbix Proxy 5.0 LTS feat(proxy_conf): Reworked jinja Template for Zabbix Proxy 5.0 LTS Aug 31, 2023
@baby-gnu
Copy link
Contributor

Please update commit message according with formulas guidelines

I've read that, and I have no idea that I need to change, sorry. Can you please give me a hint what exactly is missing?

Hello, you can execute a git commit --amend -m "feat(templates): rework for Zabbix Proxy 5.0 LTS" and then force push.

Note that the MR title is irrelevant here.

Copy link
Collaborator

@hatifnatt hatifnatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately CI is broken but changes looks good for me.

@hatifnatt hatifnatt merged commit 96c9dc0 into saltstack-formulas:master Aug 31, 2023
5 of 7 checks passed
@xenadmin xenadmin deleted the patch-3 branch August 31, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants