Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert requirements for psutil and allow for connections / net_connections based on psutil version #55

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

dmurphy18
Copy link
Collaborator

Rigid support for net_connections was causing breakages, hence monitor version of psutil and call connections vs net_connections appropriately

@dmurphy18 dmurphy18 self-assigned this Oct 22, 2024
@dmurphy18 dmurphy18 requested a review from a team as a code owner October 22, 2024 20:47
@dmurphy18 dmurphy18 requested a review from dwoz October 22, 2024 20:47
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 22.72727% with 17 lines in your changes missing coverage. Please review.

Project coverage is 90.74%. Comparing base (cb4f180) to head (b99909e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/pytestshellutils/shell.py 22.73% 15 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #55      +/-   ##
==========================================
- Coverage   92.07%   90.74%   -1.33%     
==========================================
  Files          22       22              
  Lines        1575     1586      +11     
  Branches      220      196      -24     
==========================================
- Hits         1450     1439      -11     
- Misses         93      112      +19     
- Partials       32       35       +3     
Flag Coverage Δ
Linux ?
Py3.10 95.64% <ø> (+4.02%) ⬆️
Py3.11 ?
Py3.8 90.42% <22.73%> (-1.19%) ⬇️
Py3.9 ?
PyTest7.4.0 90.42% <22.73%> (-1.20%) ⬇️
PyTest8.0.0 90.55% <22.73%> (-1.07%) ⬇️
Windows 95.64% <ø> (+4.52%) ⬆️
macOS 90.42% <22.73%> (-0.69%) ⬇️
src 84.78% <22.73%> (-2.17%) ⬇️
tests 95.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/pytestshellutils/shell.py 85.78% <22.73%> (-4.06%) ⬇️

... and 2 files with indirect coverage changes

@dmurphy18 dmurphy18 merged commit 37cce29 into saltstack:main Oct 22, 2024
30 of 34 checks passed
@dmurphy18 dmurphy18 deleted the adj_net_connections branch October 22, 2024 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants