Allow skipping test cases that need Internet access #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdrung
added a commit
to bdrung/pytest-skip-markers
that referenced
this pull request
Apr 15, 2022
Mark test cases that need Internet access and allow skipping them by setting the environment variable `NO_INTERNET`. Forwarded: saltstack#16 Signed-off-by: Benjamin Drung <bdrung@debian.org>
bdrung
force-pushed
the
support-preventing-internet-access
branch
2 times, most recently
from
f3e9404 to
3320fe9
Compare
bdrung
added a commit
to bdrung/pytest-skip-markers
that referenced
this pull request
Apr 15, 2022
Mark test cases that need Internet access and allow skipping them by setting the environment variable `NO_INTERNET`. Forwarded: saltstack#16 Signed-off-by: Benjamin Drung <bdrung@debian.org>
s0undt3ch
suggested changes
Apr 16, 2022
s0undt3ch
force-pushed
the
support-preventing-internet-access
branch
from
3320fe9 to
9858e3a
Compare
Codecov Report
@@ Coverage Diff @@
## main #16 +/- ##
===========================================
- Coverage 93.09% 80.92% -12.16%
===========================================
Files 43 53 +10
Lines 1605 2463 +858
===========================================
+ Hits 1494 1993 +499
- Misses 111 470 +359
Flags with carried forward coverage won't be shown. Click here to find out more.
|
bdrung
force-pushed
the
support-preventing-internet-access
branch
from
e418b85 to
ccc4aa4
Compare
Support skipping all test cases that access the Internet by setting the environment variable `NO_INTERNET`. This is useful to make the test run reproducible and robust for future runs (to avoid breaking in case some random service on the Internet changes). Signed-off-by: Benjamin Drung <bdrung@debian.org> Co-authored-by: Pedro Algarvio <pedro@algarvio.me>
bdrung
force-pushed
the
support-preventing-internet-access
branch
from
ccc4aa4 to
8b6960f
Compare
|
Added |
s0undt3ch
approved these changes
Apr 26, 2022
|
Thank You! |
|
Released on 1.3.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support skipping all test cases that access the Internet by setting the environment variable
NO_INTERNET. This is useful to make the test run reproducible and robust for future runs (to avoid breaking in case some random service on the Internet changes).