Fix namespaced packages #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwoz
force-pushed
the
target_namespace
branch
2 times, most recently
from
d32eda8 to
f155300
Compare
dwoz
force-pushed
the
target_namespace
branch
from
f155300 to
461918a
Compare
dmurphy18
approved these changes
Feb 16, 2024
dwoz
force-pushed
the
target_namespace
branch
from
13a8946 to
f78ca76
Compare
s0undt3ch
reviewed
Feb 17, 2024
| mod = importlib.import_module(name) | ||
|
|
||
| def wrap(func): | ||
| if mod.InstallRequirement.install.__code__.co_argcount == 9: |
There was a problem hiding this comment.
And of they remove an argument and add another?
Looks brittle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for saltstack/salt#65433