Add examples extension #54

MKLeb · 2023-05-24T22:02:54Z

Create a salt extension in an examples directory that allows you to test out pipelines using plugins that are not part of the core of salt-analytics-framework

examples/setup.cfg

examples/src/saltext/examples/__init__.py

… the package name, clarify the directory name), and remove the salt-loader entrypoint

…uirements files

s0undt3ch

What about making the examples tests part of the examples plugins, but we also run those tests, given, separately?

examples/setup.cfg

noxfile.py

src/saf/process/jupyter_notebook.py

…caping happens on Windows when using os.sep

…he model

s0undt3ch

Almost there!

.github/workflows/ci.yml

.pre-commit-config.yaml

examples/tests/pipelines/test_mnist_network.py

examples/tests/pipelines/test_mnist_notebook.py

…o setup.cfg

…ppearance on GH output

Initial stripped down extension

bd8cdd4

vmwclabot added the cla-not-required label May 24, 2023

s0undt3ch reviewed May 25, 2023

View reviewed changes

examples/setup.cfg Outdated Show resolved Hide resolved

examples/setup.cfg Outdated Show resolved Hide resolved

examples/setup.cfg Outdated Show resolved Hide resolved

examples/src/saltext/examples/__init__.py Outdated Show resolved Hide resolved

MKLeb added 6 commits May 25, 2023 15:28

Make it more obvious that this is examples for salt analytics (change…

90a6555

… the package name, clarify the directory name), and remove the salt-loader entrypoint

Add initial requirements setup

4d3e418

initial requirements setup

8fffed2

Add examples tests and add pre-commit step for combining examples req…

a9c2bbf

…uirements files

Run pre-commit

79c2b01

Use a set, order doesn't matter

8387e07

s0undt3ch reviewed May 31, 2023

View reviewed changes

examples/setup.cfg Outdated Show resolved Hide resolved

noxfile.py Outdated Show resolved Hide resolved

src/saf/process/jupyter_notebook.py Outdated Show resolved Hide resolved

MKLeb added 10 commits May 31, 2023 11:09

We don't support Python < 3.7, and we need to ensure no accidental es…

9187f23

…caping happens on Windows when using os.sep

Fix example plugins test, we switched to an underscore for consistency

5edbc55

Move the examples tests to be inside the examples subdirectory

5165a0c

Avoid Duplicate module named 'tests'

62b3b86

It's examples, not extras

391b08c

Remove the old example plugins test

0b4cfdb

Don't hardcode the tests directory in ci.yml

ff7cabc

Add example pipeline instructions

9948dd7

Skip the machine learning tests on windows, they are unable to load t…

aa7139e

…he model

Pin to a lower importlib-metadata requirement

d31f374

s0undt3ch suggested changes Jun 1, 2023

View reviewed changes

.github/workflows/ci.yml Outdated Show resolved Hide resolved

.pre-commit-config.yaml Outdated Show resolved Hide resolved

examples/tests/pipelines/test_mnist_network.py Outdated Show resolved Hide resolved

examples/tests/pipelines/test_mnist_notebook.py Outdated Show resolved Hide resolved

MKLeb added 2 commits June 1, 2023 10:30

Make pytestmark always a multiline list and move mypy configuration t…

999cccd

…o setup.cfg

Switch to testsuite string value instead of boolean value for nicer a…

7d6cf16

…ppearance on GH output

MKLeb changed the title ~~[WIP] Add examples extension~~ Add examples extension Jun 1, 2023

Changelog

b99ec4e

s0undt3ch approved these changes Jun 1, 2023

View reviewed changes

s0undt3ch merged commit c287de9 into saltstack:main Jun 1, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add examples extension #54

Add examples extension #54

MKLeb commented May 24, 2023

s0undt3ch left a comment

s0undt3ch left a comment

Add examples extension #54

Add examples extension #54

Conversation

MKLeb commented May 24, 2023

s0undt3ch left a comment

Choose a reason for hiding this comment

s0undt3ch left a comment

Choose a reason for hiding this comment