Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Issue 394 #455

Merged
merged 1 commit into from
Jul 9, 2015
Merged

PR: Issue 394 #455

merged 1 commit into from
Jul 9, 2015

Conversation

denmat
Copy link
Contributor

@denmat denmat commented Sep 1, 2014

When using Vagrant and Docker the Salt provisioner would fail as
Upstart is not running (and will most likely never be).

The easiest way to fix this is to get Docker to drop a file onto the
the filesystem (/tmp/disable_salt_checks) and then disable the service
checks from that.

Then to make it clear and optional from the command line I thought of
adding the -d argument option to do the same thing. If either of these
are present a warning message appears in the stdout.

For a Dockerfile you would add:
RUN touch /tmp/disable_salt_checks

To run from the command line you would do:
$ ./bootstrap-salt.sh -d

This adds the following var (defaults to $BS_FALSE):
_DISABLE_SALT_CHECKS

@ghost
Copy link

ghost commented Sep 1, 2014

Test PASSed.
Refer to this link for build results: http://cookingwithsalt.org/job/bootstrap/job/pr/job/build/67/

@denmat
Copy link
Contributor Author

denmat commented Sep 2, 2014

Linking to: #394

@slafs
Copy link

slafs commented Nov 16, 2014

+1 from me. although this doesn't patch well with current version of the script. needs rebasing

@jfindlay
Copy link
Contributor

@denmat, what is the status on this? Is the problem described still happening? Can this be rebased?

When using Vagrant and Docker the Salt provisioner would fail as
Upstart is not running (and will most likely never be).

The easiest way to fix this is to get Docker to drop a file onto the
the filesystem (/tmp/disable_salt_checks) and then disable the service
checks from that.

Then to make it clear and optional from the command line I thought of
adding the -d argument option to do the same thing. If either of these
are present a warning message appears in the stdout.

For a Dockerfile you would add:
RUN touch /tmp/disable_salt_checks

To run from the command line you would do:
$ ./bootstrap-salt.sh -d

This adds the following var (defaults to $BS_FALSE):
_DISABLE_SALT_CHECKS
@denmat
Copy link
Contributor Author

denmat commented May 17, 2015

Current bootstrap still produces:

Processing triggers for ureadahead (0.100.0-16) ...
 *  INFO: Running install_ubuntu_check_services()
 * ERROR: Failed to run install_ubuntu_check_services()!!!

Have rebased.

@jfindlay
Copy link
Contributor

Thanks, @denmat. @s0undt3ch, what do you think?

s0undt3ch added a commit that referenced this pull request Jul 9, 2015
@s0undt3ch s0undt3ch merged commit 1b462ce into saltstack:develop Jul 9, 2015
@s0undt3ch
Copy link
Contributor

Thank You! Sorry for the long wait.

@theladyjaye
Copy link

Using the following: (note the use /develop in the bootstrap url)

curl -L https://bootstrap.saltstack.com/develop | sh -s -- git v2014.7.1

Dockerfile:

FROM ubuntu:latest
RUN apt-get -y update && apt-get install -y curl vim
RUN curl -L https://bootstrap.saltstack.com/develop | sh -s -- git v2014.7.1

I still get the following error on Ubuntu 14.04.2:

Writing /usr/lib/python2.7/dist-packages/salt-2014.7.1.egg-info
 *  INFO: Running install_ubuntu_git_post()
 *  WARN: Upstart does not appear to know about salt-minion
 *  INFO: Running install_ubuntu_check_services()
 * ERROR: Failed to run install_ubuntu_check_services()!!!
The command '/bin/sh -c curl -L https://bootstrap.saltstack.com/develop | sh -s -- git v2014.7.1' returned a non-zero code: 1

@s0undt3ch
Copy link
Contributor

You are missing the introduced -d flag.

RUN curl -L https://bootstrap.saltstack.com/develop | sh -s -- -d git v2014.7.1

@theladyjaye
Copy link

I literally just realized that and then felt just terrible for even posting the original message.. sorry for that

=,(

@s0undt3ch
Copy link
Contributor

No worries!!!

s0undt3ch added a commit to s0undt3ch/salt that referenced this pull request Jul 17, 2015
* Make sure setuptools is installed before using it. saltstack/salt-bootstrap#598.
* `systemd` is only fully supported from 15.04 onwards. saltstack/salt-bootstrap#602
* Fix debian mirrors issue. Thanks Wolodja Wentland(babilen). saltstack/salt-bootstrap#606
* Fix python-jinja2 repo move on RHEL6. Thanks lomeroe. saltstack/salt-bootstrap#621
* Allow skipping services. Thanks denmat. saltstack/salt-bootstrap#455
* Fix missing Debian init script. saltstack/salt-bootstrap#607 saltstack#25270 and saltstack#25456
* Fix SmartOS etc path. Thanks Bret Fisher. saltstack/salt-bootstrap#624
* Fix possible unbound variable in Gentoo. saltstack/salt-bootstrap#625
* Properly detect the git binary in SmartOS. saltstack/salt-bootstrap#611
s0undt3ch added a commit to s0undt3ch/salt that referenced this pull request Jul 17, 2015
* Make sure setuptools is installed before using it. saltstack/salt-bootstrap#598.
* `systemd` is only fully supported from 15.04 onwards. saltstack/salt-bootstrap#602
* Fix debian mirrors issue. Thanks Wolodja Wentland(babilen). saltstack/salt-bootstrap#606
* Fix python-jinja2 repo move on RHEL6. Thanks lomeroe. saltstack/salt-bootstrap#621
* Allow skipping services. Thanks denmat. saltstack/salt-bootstrap#455
* Fix missing Debian init script. saltstack/salt-bootstrap#607 saltstack#25270 and saltstack#25456
* Fix SmartOS etc path. Thanks Bret Fisher. saltstack/salt-bootstrap#624
* Fix possible unbound variable in Gentoo. saltstack/salt-bootstrap#625
* Properly detect the git binary in SmartOS. saltstack/salt-bootstrap#611
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants