-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Issue 394 #455
PR: Issue 394 #455
Conversation
Test PASSed. |
Linking to: #394 |
+1 from me. although this doesn't patch well with current version of the script. needs rebasing |
@denmat, what is the status on this? Is the problem described still happening? Can this be rebased? |
When using Vagrant and Docker the Salt provisioner would fail as Upstart is not running (and will most likely never be). The easiest way to fix this is to get Docker to drop a file onto the the filesystem (/tmp/disable_salt_checks) and then disable the service checks from that. Then to make it clear and optional from the command line I thought of adding the -d argument option to do the same thing. If either of these are present a warning message appears in the stdout. For a Dockerfile you would add: RUN touch /tmp/disable_salt_checks To run from the command line you would do: $ ./bootstrap-salt.sh -d This adds the following var (defaults to $BS_FALSE): _DISABLE_SALT_CHECKS
Current bootstrap still produces:
Have rebased. |
Thanks, @denmat. @s0undt3ch, what do you think? |
Thank You! Sorry for the long wait. |
Using the following: (note the use /develop in the bootstrap url)
Dockerfile:
I still get the following error on Ubuntu 14.04.2:
|
You are missing the introduced
|
I literally just realized that and then felt just terrible for even posting the original message.. sorry for that =,( |
No worries!!! |
* Make sure setuptools is installed before using it. saltstack/salt-bootstrap#598. * `systemd` is only fully supported from 15.04 onwards. saltstack/salt-bootstrap#602 * Fix debian mirrors issue. Thanks Wolodja Wentland(babilen). saltstack/salt-bootstrap#606 * Fix python-jinja2 repo move on RHEL6. Thanks lomeroe. saltstack/salt-bootstrap#621 * Allow skipping services. Thanks denmat. saltstack/salt-bootstrap#455 * Fix missing Debian init script. saltstack/salt-bootstrap#607 saltstack#25270 and saltstack#25456 * Fix SmartOS etc path. Thanks Bret Fisher. saltstack/salt-bootstrap#624 * Fix possible unbound variable in Gentoo. saltstack/salt-bootstrap#625 * Properly detect the git binary in SmartOS. saltstack/salt-bootstrap#611
* Make sure setuptools is installed before using it. saltstack/salt-bootstrap#598. * `systemd` is only fully supported from 15.04 onwards. saltstack/salt-bootstrap#602 * Fix debian mirrors issue. Thanks Wolodja Wentland(babilen). saltstack/salt-bootstrap#606 * Fix python-jinja2 repo move on RHEL6. Thanks lomeroe. saltstack/salt-bootstrap#621 * Allow skipping services. Thanks denmat. saltstack/salt-bootstrap#455 * Fix missing Debian init script. saltstack/salt-bootstrap#607 saltstack#25270 and saltstack#25456 * Fix SmartOS etc path. Thanks Bret Fisher. saltstack/salt-bootstrap#624 * Fix possible unbound variable in Gentoo. saltstack/salt-bootstrap#625 * Properly detect the git binary in SmartOS. saltstack/salt-bootstrap#611
When using Vagrant and Docker the Salt provisioner would fail as
Upstart is not running (and will most likely never be).
The easiest way to fix this is to get Docker to drop a file onto the
the filesystem (/tmp/disable_salt_checks) and then disable the service
checks from that.
Then to make it clear and optional from the command line I thought of
adding the -d argument option to do the same thing. If either of these
are present a warning message appears in the stdout.
For a Dockerfile you would add:
RUN touch /tmp/disable_salt_checks
To run from the command line you would do:
$ ./bootstrap-salt.sh -d
This adds the following var (defaults to $BS_FALSE):
_DISABLE_SALT_CHECKS