Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from COPR repo to Saltstack Repo #671

Closed
wants to merge 1 commit into from

Conversation

timwsuqld
Copy link

Fix for Issue #668
We no longer need COPR repository now that Saltstack have offical repo's.

@rallytime
Copy link
Contributor

@timwsuqld Thanks for this fix! Looks good to me. @s0undt3ch Can you review this when you get a moment?

@jfindlay
Copy link
Contributor

@timwsuqld, this is great, although I'm loth to remove copr support (Will we ever need it again in the future?).

@timwsuqld
Copy link
Author

@jfindlay One way we look at this kind of thing at work, is it's in git, so not hard to got back and get the few functions back. Happy to modify this to include the copr repo, but they'll be functions that aren't being called by anything, so may end up not working as no one will be using them, so they won't be getting tested.

@jfindlay
Copy link
Contributor

@timwsuqld, yes, you are right, sorry for the dithering.

@jfindlay
Copy link
Contributor

@timwsuqld, since fedora packages have not yet been integrated into repo.saltstack.com, would you mind reworking this so that fedora still has access to the COPR repo? If you don't have time for this, then I can work on it. Thanks.

@timwsuqld
Copy link
Author

@jfindlay Before I try and work this more, am I correct in assuming that #674 brings in these changes anyway and we can now close this?

@jfindlay
Copy link
Contributor

@timwsuqld, that is correct.

@timwsuqld
Copy link
Author

Closing as #674 fixes this

@timwsuqld timwsuqld closed this Oct 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants