Put back deprecation warnings

Checked the https://docs.python.org/3/library/warnings.html#warnings.filterwarnings docs but there wasn't any obvious reason why our warnings disappear. This restores the DeprecationWarnings showing up on the command line.
saltstack · Dec 20, 2022 · 25d6780 · 25d6780
1 parent 168d2c9
commit 25d6780
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/changelog/62185.fixed b/changelog/62185.fixed
@@ -0,0 +1 @@
+Restored Salt's DeprecationWarnings
diff --git a/salt/__init__.py b/salt/__init__.py
@@ -58,7 +58,8 @@ def load_module(self, name):
     "",  # No deprecation message match
     DeprecationWarning,  # This filter is for DeprecationWarnings
     r"^(salt|salt\.(.*))$",  # Match module(s) 'salt' and 'salt.<whatever>'
-    append=True,
+    # Do *NOT* add append=True here - if we do, salt's DeprecationWarnings will
+    # never show up
 )
 
 # Filter the backports package UserWarning about being re-imported