Implement review feedback

saltstack · Nov 13, 2023 · eda790d · eda790d
1 parent e0e6546
commit eda790d
Show file tree

Hide file tree

Showing 2 changed files with 111 additions and 103 deletions.
diff --git a/tests/pytests/unit/utils/parsers/test_daemon_mixin.py b/tests/pytests/unit/utils/parsers/test_daemon_mixin.py
@@ -13,8 +13,7 @@
 @pytest.fixture
 def daemon_mixin():
     mixin = salt.utils.parsers.DaemonMixIn()
-    mixin.config = {}
-    mixin.config["pidfile"] = "/some/fake.pid"
+    mixin.config = {"pidfile": "/some/fake.pid"}
     return mixin
 
 
@@ -26,7 +25,7 @@ def test_pid_file_deletion(daemon_mixin):
         with patch("os.path.isfile", MagicMock(return_value=True)):
             with patch("salt.utils.parsers.log", MagicMock()) as log_mock:
                 daemon_mixin._mixin_before_exit()
-                assert unlink_mock.call_count == 1
+                unlink_mock.assert_called_once()
                 log_mock.info.assert_not_called()
                 log_mock.debug.assert_not_called()