'force' option in copy state deletes target file

[wipfs]

[root@minion]# cat /var/cache/salt/minion/files/base/example/init.sls
/tmp/test:
  file.copy:
    - source: /tmp/test_src
    - force: True

This will behave as expected if the target does not exist or if it is identical to the source
If however the target exists but is different from the source, then this state simply deletes the target, though it claims not to overwrite it:

[root@minion]# ls -l /tmp/test /tmp/test_src
-rw-r--r--. 1 root root 192 Jul  8 12:20 /tmp/test
-rw-r--r--. 1 root root 198 Jul  8 12:19 /tmp/test_src

[root@minion]# salt-call state.sls example
[INFO    ] Loading fresh modules for state activity
[INFO    ] Fetching file from saltenv 'base', ** skipped ** latest already in cache 'salt://example/init.sls'
[INFO    ] Running state [/tmp/test] at time 12:20:58.419543
[INFO    ] Executing state file.copy for /tmp/test
[INFO    ] The target file "/tmp/test" exists and will not be overwritten
[INFO    ] Completed state [/tmp/test] at time 12:20:58.421524
local:

          ID: /tmp/test
    Function: file.copy
      Result: True
     Comment: The target file "/tmp/test" exists and will not be overwritten
     Started: 12:20:58.419543
    Duration: 1.981 ms
     Changes:

Summary

Succeeded: 1
Failed:    0

Total states run:     1

[root@minion]# ls -l /tmp/test /tmp/test_src
ls: cannot access /tmp/test: No such file or directory
-rw-r--r--. 1 root root 198 Jul  8 12:19 /tmp/test_src

[root@minion-1]# salt --version
salt 2015.5.2 (Lithium)

[jfindlay]

@wipfs, thanks for the report.

[thunderk]

This is a rather critical bug as it may cause missing files, and so broken services. Maybe some unit tests would be good to avoid future regressions on this ?

[jfindlay]

@thunderk, good ideas, thanks.

[cachedout]

The fix and the test are both merged now. Thanks to all who helped out here! I'll go ahead and close this.