Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

salt-cloud: scp_file() and sftp_file() don't work with ipv4-only hosts #33299

Closed
jbonachera opened this issue May 17, 2016 · 1 comment
Closed

salt-cloud: scp_file() and sftp_file() don't work with ipv4-only hosts #33299

jbonachera opened this issue May 17, 2016 · 1 comment
Labels
Bug broken, incorrect, or confusing behavior P2 Priority 2 RIoT Relates to integration with cloud providers, hypervisors, API-based services, etc. Salt-Cloud severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around
Milestone
Approved

Comments

@jbonachera
Copy link
Contributor

Description of Issue/Question

This is the same issue as #33243, but for other functions.

Salt-cloud scp_file() and sftp_file() can't successfully establish a connection to an ipv4-only host, for the same reason as #33243: "inet_pton was being treated as if it would return a falsy response, when in fact it raised an exception instead".

Setup

Standard salt-cloud + openstack setup, talking to an Openstack platform, using SSH and ssh-keys authentication for bootstraping.

This setup works with Salt 2015.8 stable version.

Steps to Reproduce Issue

Run a salt-cloud deployment using SSH as authentication method.
@jbonachera jbonachera mentioned this issue May 17, 2016
Merged
rallytime pushed a commit that referenced this issue May 17, 2016
@jbonachera
Handle more ipv6 error as an exception #33299 (#33300)
7a181f2 
* Handle ipv6 exception in scp_file()

* Handle ipv6 exception in sftp_file()
@rallytime
Copy link
Contributor

rallytime commented May 17, 2016 •
edited
Loading

Hi @jbonachera - thank you for filing this issue, and for submitting the fix. We love it when that happens! :)

I just merged your fix, so I'll go ahead and close this up. Thanks!

@rallytime rallytime added Bug broken, incorrect, or confusing behavior severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around Salt-Cloud P2 Priority 2 RIoT Relates to integration with cloud providers, hypervisors, API-based services, etc. labels May 17, 2016
@rallytime rallytime added this to the Approved milestone May 17, 2016
gitebra pushed a commit to gitebra/salt that referenced this issue May 18, 2016
@jojohans
Merge remote-tracking branch 'upstream/develop' into develop
383597b 
* upstream/develop: (23 commits)
  Don't merge-forward the change to salt/scripts.py
  Cleanup comments in smbios.get output (fixes saltstack#33266) (saltstack#33306)
  Back-port saltstack#32993 to 2016.3 (saltstack#33304)
  Fix iptables --match-set (saltstack#23643) (saltstack#33314)
  Improve package verification documentation
  Accept verify_options and ignore_types as a comma-separated list
  Fix minion start retry on Windows (2016.3) (saltstack#33285)
  update 2015.8.9 release notes (saltstack#33310)
  Added some more docs for master and minion config settings (saltstack#33292)
  linux_acl: Allow '-' as a separation character in ACL permissions. Fixes saltstack#31270 (saltstack#33172) (saltstack#33305)
  Server Density agentv2 support (saltstack#32772) (saltstack#33303)
  man pages updated (saltstack#33307)
  Fix iptables --match-set (saltstack#23643) (saltstack#33301)
  Handle more ipv6 error as an exception saltstack#33299 (saltstack#33300)
  Ignore retcode when checking service's status (saltstack#33294)
  fix "loose" typo (saltstack#33290)
  Fix minion start retry on Windows
  Add auth_tries config option to minion.rst docs (saltstack#33287)
  Document new master and minion config opts for 2016.3.0
  Document minion_id_caching config value (saltstack#33282)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug broken, incorrect, or confusing behavior P2 Priority 2 RIoT Relates to integration with cloud providers, hypervisors, API-based services, etc. Salt-Cloud severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around
Projects
None yet
Milestone
Approved
Development

No branches or pull requests
2 participants
@jbonachera @rallytime