Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PKI files should live in /var/lib #3396

Closed
madduck opened this issue Jan 23, 2013 · 5 comments · Fixed by #61453
Closed

PKI files should live in /var/lib #3396

madduck opened this issue Jan 23, 2013 · 5 comments · Fixed by #61453

Comments

@madduck
Copy link
Contributor

madduck commented Jan 23, 2013

The files in /etc/salt/pki are not configuration files in the sense of the FHS ("local file used to control the operation of a program") and hence do not belong in /etc.

The FHS-proper location for these auto-generated but static files is /var/lib. I suggest that the defaults be changed to `/var/lib/salt/{master,minion}/pki.

To assist users with the migration, /etc/salt/pki could be used as a fallback, in combination with an appropriate warning and reference to a README file or so.
@madduck
Copy link
Contributor Author

madduck commented Jan 23, 2013

On the minion, the minion subdirectory won't be necessary either, that is: /etc/salt/pki/minion → /var/lib/salt/minion/pki.

@thatch45
Copy link
Contributor

I am sorry @madduck, I don't think we should change the default here. In freebsd for instance this is a violation, and in Red Hat they often put certs in /etc/pki
In the end this is a distro specific thing, also, it is configurable via the pki_dir option

@madduck
Copy link
Contributor Author

madduck commented Jan 24, 2013

I am sorry @madduck, I don't think we should change the default
here. In freebsd for instance this is a violation, and in Red Hat
they often put certs in /etc/pki

Sure, every distro does their own thing, which is why I was
suggesting to go by the only accepted higher-level standard, which
the FHS undoubtedly is.

@thatch45
Copy link
Contributor

But distro and especially unixes do not follow this standard, this is a dead end debate and I would prefer to not get drawn into it, if our package maintainers all agree that we should create a new sub-directory and recreate all keys so that they can foll the FHS that is their thing.

@madduck
Copy link
Contributor Author

madduck commented Jan 25, 2013

For future reference: http://bugs.debian.org/698898

@ghost ghost mentioned this issue Jan 25, 2013
Closed
@bdrung bdrung mentioned this issue Feb 21, 2018
Closed
bdrung added a commit to bdrung/salt that referenced this issue Feb 28, 2018
@bdrung
Make default pki directory configurable
e339383 
The files in /etc/salt/pki are not configuration files in the sense
of the FHS ("local file used to control the operation of a program").
Debian wants to change the default location to /var/lib/salt/pki (to
properly follow FHS and to allow setting StateDirectory in the salt
master systemd configuration).

Therefore introduce a VARIABLE_STATE_DIR syspaths variable which
defaults to CONFIG_DIR, but can be individually customized.

fixes saltstack#3396
Bug-Debian: https://bugs.debian.org/698898
@bdrung bdrung mentioned this issue Mar 1, 2018
Closed
bdrung added a commit to bdrung/salt that referenced this issue Mar 15, 2018
@bdrung
Make default pki directory configurable
d515b38 
The files in /etc/salt/pki are not configuration files in the sense
of the FHS ("local file used to control the operation of a program").
Debian wants to change the default location to /var/lib/salt/pki (to
properly follow FHS and to allow setting StateDirectory in the salt
master systemd configuration).

Therefore introduce a VARIABLE_STATE_DIR syspaths variable which
defaults to CONFIG_DIR, but can be individually customized.

fixes saltstack#3396
Bug-Debian: https://bugs.debian.org/698898
bdrung added a commit to bdrung/salt that referenced this issue Jan 24, 2020
@bdrung
Make default pki directory configurable
6ec2931 
The files in /etc/salt/pki are not configuration files in the sense
of the FHS ("local file used to control the operation of a program").
Debian wants to change the default location to /var/lib/salt/pki (to
properly follow FHS and to allow setting StateDirectory in the salt
master systemd configuration).

Therefore introduce a STATE_DIR syspaths variable which defaults to
CONFIG_DIR, but can be individually customized.

fixes saltstack#3396
Bug-Debian: https://bugs.debian.org/698898
Forwarded: saltstack#46277
bdrung added a commit to bdrung/salt that referenced this issue Jun 22, 2020
@bdrung
Make default pki directory configurable
3471d21 
The files in /etc/salt/pki are not configuration files in the sense
of the FHS ("local file used to control the operation of a program").
Debian wants to change the default location to /var/lib/salt/pki (to
properly follow FHS and to allow setting StateDirectory in the salt
master systemd configuration).

Therefore introduce a STATE_DIR syspaths variable which defaults to
CONFIG_DIR, but can be individually customized.

fixes saltstack#3396
Bug-Debian: https://bugs.debian.org/698898
Forwarded: saltstack#46277
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
bdrung added a commit to bdrung/salt that referenced this issue Oct 9, 2020
@bdrung
Make default pki directory configurable
3ee3507 
The files in /etc/salt/pki are not configuration files in the sense
of the FHS ("local file used to control the operation of a program").
Debian wants to change the default location to /var/lib/salt/pki (to
properly follow FHS and to allow setting StateDirectory in the salt
master systemd configuration).

Therefore introduce a STATE_DIR syspaths variable which defaults to
CONFIG_DIR, but can be individually customized.

fixes saltstack#3396
Bug-Debian: https://bugs.debian.org/698898
Forwarded: saltstack#46277
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
bdrung added a commit to bdrung/salt that referenced this issue Oct 22, 2020
@bdrung
Make default pki directory configurable
6e64f34 
The files in /etc/salt/pki are not configuration files in the sense
of the FHS ("local file used to control the operation of a program").
Debian wants to change the default location to /var/lib/salt/pki (to
properly follow FHS and to allow setting StateDirectory in the salt
master systemd configuration).

Therefore introduce a STATE_DIR syspaths variable which defaults to
CONFIG_DIR, but can be individually customized.

fixes saltstack#3396
Bug-Debian: https://bugs.debian.org/698898
Forwarded: saltstack#46277
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
bdrung added a commit to bdrung/salt that referenced this issue May 12, 2021
@bdrung
Make default pki directory configurable
366f63b 
The files in /etc/salt/pki are not configuration files in the sense
of the FHS ("local file used to control the operation of a program").
Debian wants to change the default location to /var/lib/salt/pki (to
properly follow FHS and to allow setting StateDirectory in the salt
master systemd configuration).

Therefore introduce a STATE_DIR syspaths variable which defaults to
CONFIG_DIR, but can be individually customized.

fixes saltstack#3396
Bug-Debian: https://bugs.debian.org/698898
Forwarded: saltstack#46277
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
bdrung added a commit to bdrung/salt that referenced this issue Oct 13, 2021
@bdrung
Make default pki directory configurable
edcf1e1 
The files in /etc/salt/pki are not configuration files in the sense
of the FHS ("local file used to control the operation of a program").
Debian wants to change the default location to /var/lib/salt/pki (to
properly follow FHS and to allow setting StateDirectory in the salt
master systemd configuration).

Therefore introduce a STATE_DIR syspaths variable which defaults to
CONFIG_DIR, but can be individually customized.

fixes saltstack#3396
Bug-Debian: https://bugs.debian.org/698898
Forwarded: saltstack#46277
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
bdrung added a commit to bdrung/salt that referenced this issue Oct 14, 2021
@bdrung
Make default pki directory configurable
570fad8 
The files in /etc/salt/pki are not configuration files in the sense
of the FHS ("local file used to control the operation of a program").
Debian wants to change the default location to /var/lib/salt/pki (to
properly follow FHS and to allow setting StateDirectory in the salt
master systemd configuration).

Therefore introduce a STATE_DIR syspaths variable which defaults to
CONFIG_DIR, but can be individually customized.

fixes saltstack#3396
Bug-Debian: https://bugs.debian.org/698898
Forwarded: saltstack#46277
Signed-off-by: Benjamin Drung <benjamin.drung@cloud.ionos.com>
@bdrung bdrung mentioned this issue Jan 13, 2022
Merged
bdrung added a commit to bdrung/salt that referenced this issue Apr 15, 2022
@bdrung
Make default pki directory configurable
3195234 
The files in `/etc/salt/pki` are not configuration files in the sense of
the FHS ("local file used to control the operation of a program").
Debian wants to change the default location to `/var/lib/salt/pki` (to
properly follow FHS and to allow setting StateDirectory in the salt
master systemd configuration).

Therefore introduce a `STATE_DIR` syspaths variable which defaults to
`CONFIG_DIR`, but can be individually customized.

fixes saltstack#3396
Bug-Debian: https://bugs.debian.org/698898
Forwarded: saltstack#61453
Signed-off-by: Benjamin Drung <benjamin.drung@ionos.com>
bdrung added a commit to bdrung/salt that referenced this issue Apr 15, 2022
@bdrung
Make default pki directory configurable
d45eae9 
The files in `/etc/salt/pki` are not configuration files in the sense of
the FHS ("local file used to control the operation of a program").
Debian wants to change the default location to `/var/lib/salt/pki` (to
properly follow FHS and to allow setting StateDirectory in the salt
master systemd configuration).

Therefore introduce a `STATE_DIR` syspaths variable which defaults to
`CONFIG_DIR`, but can be individually customized.

fixes saltstack#3396
Bug-Debian: https://bugs.debian.org/698898
Forwarded: saltstack#61453
Signed-off-by: Benjamin Drung <benjamin.drung@ionos.com>
bdrung added a commit to bdrung/salt that referenced this issue Apr 16, 2022
@bdrung
Make default pki directory configurable
48c4a62 
The files in `/etc/salt/pki` are not configuration files in the sense of
the FHS ("local file used to control the operation of a program").
Debian wants to change the default location to `/var/lib/salt/pki` (to
properly follow FHS and to allow setting StateDirectory in the salt
master systemd configuration).

Therefore introduce a `STATE_DIR` syspaths variable which defaults to
`CONFIG_DIR`, but can be individually customized.

fixes saltstack#3396
Bug-Debian: https://bugs.debian.org/698898
Forwarded: saltstack#61453
Signed-off-by: Benjamin Drung <benjamin.drung@ionos.com>
bdrung added a commit to bdrung/salt that referenced this issue Sep 29, 2022
@bdrung
Make default pki directory configurable
d293432 
The files in `/etc/salt/pki` are not configuration files in the sense of
the FHS ("local file used to control the operation of a program").
Debian wants to change the default location to `/var/lib/salt/pki` (to
properly follow FHS and to allow setting StateDirectory in the salt
master systemd configuration).

Therefore introduce a `LIB_STATE_DIR` syspaths variable which defaults
to `CONFIG_DIR`, but can be individually customized.

fixes saltstack#3396
Bug-Debian: https://bugs.debian.org/698898
Signed-off-by: Benjamin Drung <benjamin.drung@ionos.com>
Ch3LL pushed a commit that referenced this issue Sep 29, 2022
@bdrung
Make default pki directory configurable
ad95c4f 
The files in `/etc/salt/pki` are not configuration files in the sense of
the FHS ("local file used to control the operation of a program").
Debian wants to change the default location to `/var/lib/salt/pki` (to
properly follow FHS and to allow setting StateDirectory in the salt
master systemd configuration).

Therefore introduce a `LIB_STATE_DIR` syspaths variable which defaults
to `CONFIG_DIR`, but can be individually customized.

fixes #3396
Bug-Debian: https://bugs.debian.org/698898
Signed-off-by: Benjamin Drung <benjamin.drung@ionos.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@madduck @thatch45