mount.mounted with 'mount: False' reports unmounted file system as unchanged when running with test=True

[tkaehn]

Description of Issue/Question

mount.mounted with 'mount: False' reports unmounted file system as unchanged when running with test=True. In contrast to this no changes are made when running with test=False.

Steps to Reproduce Issue

root@master:/srv/salt# cat mount.sls 
---
/mnt/proc:
  mount.mounted:
    - device: proc
    - fstype: proc
    - mount: False
    - mkmnt: True
root@master:/srv/salt# mount|grep mnt
root@master:/srv/salt# salt-call state.apply mount --state-output=changes test=True
local:
----------
          ID: /mnt/proc
    Function: mount.mounted
      Result: None
     Comment: /mnt/proc would not be mounted. Entry already exists in the fstab.
     Started: 09:25:01.512901
    Duration: 37.503 ms
     Changes:   

Summary for local
------------
Succeeded: 1 (unchanged=1)
Failed:    0
------------
Total states run:     1
Total run time:  37.503 ms
root@master:/srv/salt# salt-call state.apply mount --state-output=changes test=False
local:
  Name: /mnt/proc - Function: mount.mounted - Result: Clean Started: - 09:25:05.841866 Duration: 36.559 ms

Summary for local
------------
Succeeded: 1
Failed:    0
------------
Total states run:     1
Total run time:  36.559 ms

Versions Report

root@master:/srv/salt# salt --versions-report
Salt Version:
           Salt: 2018.3.0
 
Dependency Versions:
           cffi: Not Installed
       cherrypy: Not Installed
       dateutil: 2.5.3
      docker-py: Not Installed
          gitdb: 2.0.0
      gitpython: 2.1.1
          ioflo: Not Installed
         Jinja2: 2.9.4
        libgit2: Not Installed
        libnacl: Not Installed
       M2Crypto: Not Installed
           Mako: Not Installed
   msgpack-pure: Not Installed
 msgpack-python: 0.4.8
   mysql-python: Not Installed
      pycparser: Not Installed
       pycrypto: 2.6.1
   pycryptodome: Not Installed
         pygit2: Not Installed
         Python: 2.7.13 (default, Nov 24 2017, 17:33:09)
   python-gnupg: Not Installed
         PyYAML: 3.12
          PyZMQ: 16.0.2
           RAET: Not Installed
          smmap: 2.0.1
        timelib: Not Installed
        Tornado: 4.4.3
            ZMQ: 4.2.1
 
System Versions:
           dist: debian 9.4 
         locale: UTF-8
        machine: x86_64
        release: 4.9.0-6-amd64
         system: Linux
        version: debian 9.4 

[Ch3LL]

i'm not able to replicate this:

local:
----------
          ID: /mnt/proc
    Function: mount.mounted
      Result: None
     Comment: /mnt/proc would be created, but not mounted. /mnt/proc needs to be written to the fstab in order to be made persistent.
     Started: 15:03:16.100883
    Duration: 261.534 ms
     Changes:   

Summary for local
------------
Succeeded: 1 (unchanged=1)
Failed:    0
------------
Total states run:     1
Total run time: 261.534 ms

can you verify its not already in your /etc/fstab and just not showing in your mount command output?

[tkaehn]

@Ch3LL I've just tried again and was able to reproduce the problem. The file system isn't mounted during the procedure. As you can see below the last run of state.apply (test=True) shows pending changes (which is wrong). However running with test=False none are applied which is the expected behaviour:

root@master:/srv/salt# salt-call state.apply mount --state-output=changes test=False
local:
----------
          ID: /mnt/proc
    Function: mount.mounted
      Result: True
     Comment: /mnt/proc was created, not mounted. Added new entry to the fstab.
     Started: 18:13:23.474193
    Duration: 29.675 ms
     Changes:   
              ----------
              persist:
                  new

Summary for local
------------
Succeeded: 1 (changed=1)
Failed:    0
------------
Total states run:     1
Total run time:  29.675 ms
root@master:/srv/salt# salt-call state.apply mount --state-output=changes test=False
local:
  Name: /mnt/proc - Function: mount.mounted - Result: Clean Started: - 18:13:28.596075 Duration: 24.125 ms

Summary for local
------------
Succeeded: 1
Failed:    0
------------
Total states run:     1
Total run time:  24.125 ms
root@master:/srv/salt# salt-call state.apply mount --state-output=changes test=True
local:
----------
          ID: /mnt/proc
    Function: mount.mounted
      Result: None
     Comment: /mnt/proc would not be mounted. Entry already exists in the fstab.
     Started: 18:13:32.716358
    Duration: 24.027 ms
     Changes:   

Summary for local
------------
Succeeded: 1 (unchanged=1)
Failed:    0
------------
Total states run:     1
Total run time:  24.027 ms

[Ch3LL]

okay did not realize you were running the state before test=True, apologies. In your first example you ran test=True so thats what i did in my use case. I'm now able to replicate the issue. Seems we can make improvements here to make sure we show that there will be no changes when run with test=True.

[tkaehn]

Problem still exists in 2019.2.0

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.

[pruiz]

This is still an issue, please keep open.

[stale]

Thank you for updating this issue. It is no longer marked as stale.