Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requirements/dev_python27.txt missing #55804

Closed
morgana2313 opened this issue Jan 7, 2020 · 7 comments
Closed

requirements/dev_python27.txt missing #55804

morgana2313 opened this issue Jan 7, 2020 · 7 comments
Assignees
Labels
Confirmed Salt engineer has confirmed bug/feature - often including a MCVE doc-rework confusing, misleading, or wrong Documentation Relates to Salt documentation needs-triage Tests

Comments

@morgana2313
Copy link
Contributor

morgana2313 commented Jan 7, 2020

Description of Issue

@garethgreenaway, @dwoz:

The test suite introduction refers to requirements/dev_python27.txt:

pip install -r requirements/dev_python27.txt
pip install -r requirements/dev_python34.txt

The same goes for the SALT'S TEST SUITE page.

I think the contents of this file moved elsewhere (requirements/static/py2.7/linux ?) and the documentation is not updated yet after #54604

@sagetherage sagetherage added Documentation Relates to Salt documentation Tests labels Jan 9, 2020
@sagetherage sagetherage added this to the Approved milestone Jan 9, 2020
@stale
Copy link

stale bot commented Feb 8, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.

@stale stale bot added the stale label Feb 8, 2020
@sagetherage sagetherage added the Confirmed Salt engineer has confirmed bug/feature - often including a MCVE label Feb 11, 2020
@stale
Copy link

stale bot commented Feb 11, 2020

Thank you for updating this issue. It is no longer marked as stale.

@stale stale bot removed the stale label Feb 11, 2020
@sagetherage sagetherage added doc-rework confusing, misleading, or wrong stale labels Feb 11, 2020
@stale
Copy link

stale bot commented Feb 11, 2020

Thank you for updating this issue. It is no longer marked as stale.

@waynew
Copy link
Contributor

waynew commented Feb 20, 2020

This issue should be handled when we re-write the testing docs, because we should be using nox to run the tests, which will take care of this invalid instruction :P

s0undt3ch added a commit to s0undt3ch/salt that referenced this issue Jun 8, 2020
dwoz pushed a commit that referenced this issue Jun 9, 2020
@sagetherage sagetherage removed this from the Approved milestone May 7, 2021
@sagetherage
Copy link
Contributor

@ScriptAutomate @waynew did we fix this in the clean up of the testing docs and contributor docs?

@morgana2313
Copy link
Contributor Author

morgana2313 commented May 7, 2021 via email

@sagetherage
Copy link
Contributor

We no longer support python 2.7 so the text should be missing, but we have done more clean up to navigate testing with nox. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Confirmed Salt engineer has confirmed bug/feature - often including a MCVE doc-rework confusing, misleading, or wrong Documentation Relates to Salt documentation needs-triage Tests
Projects
None yet
Development

No branches or pull requests

5 participants