Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG][DOCS] develop link in PR contributing #59472

Closed
sagetherage opened this issue Feb 10, 2021 · 0 comments · Fixed by #59538
Closed

[BUG][DOCS] develop link in PR contributing #59472

sagetherage opened this issue Feb 10, 2021 · 0 comments · Fixed by #59538
Assignees
@ScriptAutomate @sagetherage
Labels
Aluminium Release Post Mg and Pre Si Bug broken, incorrect, or confusing behavior doc-correction docu page has an error or deadlink Documentation Relates to Salt documentation good first issue good for someone new to salt severity-high 2nd top severity, seen by most users, causes major problems
Milestone
Aluminium

Comments

@sagetherage
Copy link
Contributor

Description
On this page: https://docs.saltproject.io/en/master/topics/development/contributing.html#pr-time
The link in the text in the first sentence "PR Guidelines" is linking to the develop branch and thus hitting a 404 page and should be going to https://docs.saltproject.io/en/master/topics/development/pull_requests.html or latest

Expected behavior
Expected to hit latest or master link that doesn't give a 404

Screenshots
Screen Shot 2021-02-10 at 9 25 02 AM
@sagetherage sagetherage added Documentation Relates to Salt documentation Bug broken, incorrect, or confusing behavior severity-high 2nd top severity, seen by most users, causes major problems doc-correction docu page has an error or deadlink Aluminium Release Post Mg and Pre Si good first issue good for someone new to salt phase-execute labels Feb 10, 2021
@sagetherage sagetherage added this to the Aluminium milestone Feb 10, 2021
@ScriptAutomate ScriptAutomate mentioned this issue Feb 23, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ScriptAutomate ScriptAutomate

@sagetherage sagetherage

Labels
Aluminium Release Post Mg and Pre Si Bug broken, incorrect, or confusing behavior doc-correction docu page has an error or deadlink Documentation Relates to Salt documentation good first issue good for someone new to salt severity-high 2nd top severity, seen by most users, causes major problems
Projects
None yet
Milestone
Aluminium
Development

Successfully merging a pull request may close this issue.

Deprecation warning for grains.get_or_set_hash w/ docs guidance on avoiding grains storage for secrets
2 participants
@ScriptAutomate @sagetherage