Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warning for grains.get_or_set_hash w/ docs guidance on avoiding grains storage for secrets #59538

Merged
merged 7 commits into from
Feb 19, 2021
Merged

Deprecation warning for grains.get_or_set_hash w/ docs guidance on avoiding grains storage for secrets #59538

merged 7 commits into from
Feb 19, 2021

Conversation

ScriptAutomate
Copy link
Contributor

@ScriptAutomate ScriptAutomate commented Feb 18, 2021

What does this PR do?

  • Fix a few links to point to the right branch in the salt repo
  • Adds deprecation warning for grains.get_or_set_hash for deprecation in Phosphorus
  • Adds .. warning:: admonition about grains and secrets

image

What issues does this PR fix or reference?

Fixes: #59425
Fixes: #59472

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

@ScriptAutomate ScriptAutomate requested a review from a team as a code owner February 18, 2021 16:53
@ScriptAutomate ScriptAutomate requested review from s0undt3ch and garethgreenaway and removed request for a team February 18, 2021 16:53
@ScriptAutomate ScriptAutomate added the Aluminium Release Post Mg and Pre Si label Feb 18, 2021
@Ch3LL Ch3LL merged commit e2b2640 into saltstack:master Feb 19, 2021
@ScriptAutomate ScriptAutomate deleted the deprecate-grains-hash branch February 19, 2021 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Aluminium Release Post Mg and Pre Si
Projects
None yet
4 participants