Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] groupadd.* functions hard code relative command name #62657

Closed
nicholasmhughes opened this issue Sep 12, 2022 · 0 comments · Fixed by #62658
Closed

[BUG] groupadd.* functions hard code relative command name #62657

nicholasmhughes opened this issue Sep 12, 2022 · 0 comments · Fixed by #62658
Labels
Bug broken, incorrect, or confusing behavior Execution-Module

Comments

@nicholasmhughes
Copy link
Collaborator

Description
Functions in the groupadd execution module have hard-coded command names which rely on the PATH environment variable to be properly set in order to run correctly.

Steps to Reproduce the behavior
On a Debian 10 system, the PATH variable was modified to remove "bin" locations where the groupadd command would be found:

# /root/.bashrc
export PATH=""

Then, any calls to groupadd will fail.

Expected behavior
It would be nice if the functions made an effort to locate the full path to the binaries.

Versions Report

salt --versions-report (Provided by running salt --versions-report. Please also mention any differences in master/minion versions.)
Salt Version:
          Salt: 3005+0na.c57a277
 
Dependency Versions:
          cffi: Not Installed
      cherrypy: Not Installed
      dateutil: Not Installed
     docker-py: Not Installed
         gitdb: Not Installed
     gitpython: Not Installed
        Jinja2: 3.1.2
       libgit2: Not Installed
      M2Crypto: Not Installed
          Mako: Not Installed
       msgpack: 1.0.4
  msgpack-pure: Not Installed
  mysql-python: Not Installed
     pycparser: Not Installed
      pycrypto: 2.6.1
  pycryptodome: 3.15.0
        pygit2: Not Installed
        Python: 3.7.3 (default, Jan 22 2021, 20:04:44)
  python-gnupg: Not Installed
        PyYAML: 6.0
         PyZMQ: 23.2.1
         smmap: Not Installed
       timelib: Not Installed
       Tornado: 4.5.3
           ZMQ: 4.3.4
 
System Versions:
          dist: debian 10 buster
        locale: UTF-8
       machine: x86_64
       release: 4.19.0-21-amd64
        system: Linux
       version: Debian GNU/Linux 10 buster
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug broken, incorrect, or confusing behavior Execution-Module
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant