Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] TCP transport documentation is out of date #63120

Closed
lukasraska opened this issue Nov 28, 2022 · 3 comments · Fixed by #63125
Closed

[DOCS] TCP transport documentation is out of date #63120

lukasraska opened this issue Nov 28, 2022 · 3 comments · Fixed by #63125
Assignees
Labels
doc-rework confusing, misleading, or wrong Documentation Relates to Salt documentation severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around time-estimate-sprint Transport

Comments

@lukasraska
Copy link
Contributor

Description
As discussed on Slack, TCP transport documentation on https://docs.saltproject.io/en/latest/topics/transports/tcp.html is not really up-to-date, for example statement As of today we send all publishes to all minions and rely on minion-side filtering. is not really correct, as there is master-side filtering and only for certain cases minion-side filtering is used

Suggested Fix
Review the documentation and update it to current behaviour

Type of documentation
Salt documentation

Location or format of documentation
https://docs.saltproject.io/en/latest/topics/transports/tcp.html

Additional context
I will prepare PR for fixing statements that are not valid anymore.

@lukasraska lukasraska added Documentation Relates to Salt documentation needs-triage labels Nov 28, 2022
@OrangeDog
Copy link
Contributor

Have you got a link to the Slack discussion?

@lukasraska
Copy link
Contributor Author

@OrangeDog OrangeDog added the doc-rework confusing, misleading, or wrong label Nov 28, 2022
@barbaricyawps
Copy link
Contributor

@lukasraska , since it sounds like you're preparing a PR, I'm going to assign you to this issue so that I know it's being worked on. Thanks for doing that work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-rework confusing, misleading, or wrong Documentation Relates to Salt documentation severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around time-estimate-sprint Transport
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants