Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct TCP transport documentation regarding master-side filtering #63125

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

lukasraska
Copy link
Contributor

What does this PR do?

Fixes mention about client-side filtering forTCP transport, plus few small changes

What issues does this PR fix or reference?

Fixes: #63120

Previous Behavior

  • Link towards ssl.wrap_socket was not correctly formatted
  • Documentation states that TCP transport supports only minion-side filtering

New Behavior

  • Link is correct
  • Ciphers configuration is mentioned in the example, as that's what you mostly want to do as well
  • Note about master-side filtering is corrected, along with links to appropriate commits that introduced that change
  • Note about default CLI filtering value is added, so users know what exactly they should be doing

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@lukasraska lukasraska requested a review from a team as a code owner November 28, 2022 17:55
@lukasraska lukasraska requested review from twangboy and removed request for a team November 28, 2022 17:55
@lukasraska
Copy link
Contributor Author

@barbaricyawps FYI

@barbaricyawps
Copy link
Contributor

Thanks, @lukasraska , I'll make sure this gets reviewed!

@barbaricyawps barbaricyawps self-requested a review November 28, 2022 17:57
Copy link
Contributor

@barbaricyawps barbaricyawps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me from a communications standpoint. I'll get an additional review on it from a subject matter expert if possible.

@Ch3LL Ch3LL requested a review from dwoz November 28, 2022 19:37
@garethgreenaway garethgreenaway merged commit ec6fef1 into saltstack:master Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOCS] TCP transport documentation is out of date
5 participants