Fix batch install on FreeBSD using pkgng #48730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For fully automated batch installing in FreeBSD you need to pass BATCH=true.
ghost
self-requested a review
rallytime
approved these changes
Jul 26, 2018
|
Welcome @fzipi! Thank you for submitting this. This looks good to me, but I'm not super familiar with FreeBSD. @abednarik You've been involved with FreeBSD support - can you review this? |
|
Hi
Sure we can review this since we use FreeBSD. Will do it next Wensday.
I'm on vacations now.
Cheers
El jue., 26 de jul. de 2018 16:20, Nicole Thomas <notifications@github.com>
escribió:
… Welcome @fzipi <https://github.com/fzipi>! Thank you for submitting this.
This looks good to me, but I'm not super familiar with FreeBSD.
@abednarik <https://github.com/abednarik> You've been involved with
FreeBSD support - can you review this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#48730 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAN9c-R3Oc4YGTitadJ8KHBYS4-Hsm_2ks5uKjKcgaJpZM4VcV45>
.
|
|
Hi @rallytime This looks good to me. Thanks. |
rallytime
added
the
bugfix-bckport
rallytime
added
ZZZ[Done]-back-ported-bf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For fully automated batch installing in FreeBSD you need to pass BATCH=true.
What does this PR do?
Add a new option to
pkg install,batch=True.What issues does this PR fix or reference?
#27056, #29907, #29909
Previous Behavior
When installing
postfixin FreeBSD, it keeps asking for confirmation to changemailer.conf. When using the postfix formula, it does not work because installation is not automated (you can break things in production, etc.).New Behavior
Installation is succesful. You may require to configure additional steps, but at least the package is there.
Tests written?
No
Commits signed with GPG?
Yes