Modify the proxmox VM when using clone in the salt-cloud profile #49256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ettings are present
ghost
self-requested a review
gtmanfred
approved these changes
Aug 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows a salt-cloud proxmox cloned VM to be modified before it's started for the first time. Previously some settings that are valid in the profile are ignored if the clone setting it used, but it is very useful to be able to modify some settings on the clone before it's started for the first time.
What does this PR do?
Allows modification of a cloned VM using the proxmox salt-cloud provider. The profile need only include the relevant settings and they will be applied after the clone is created and before the clone is started.
What issues does this PR fix or reference?
#49254
Previous Behavior
Settings like
ide2are silently ignoredNew Behavior
Settings like
ide2take effect on the cloned VMTests written?
No - but if there's a test suite surrounding this the PR can be updated.
Commits signed with GPG?
No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.