-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port json_query Jinja filter from Ansible #50428
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-requested a review
November 8, 2018 08:52
dwoz
approved these changes
Nov 8, 2018
isbm
suggested changes
Nov 8, 2018
isbm
suggested changes
Nov 8, 2018
max-arnold
force-pushed
the
json-query
branch
from
November 8, 2018 13:32
6dd29cf
to
d9e89ac
Compare
max-arnold
force-pushed
the
json-query
branch
from
November 8, 2018 13:32
d9e89ac
to
f6b49c3
Compare
isbm
approved these changes
Nov 8, 2018
Are jinja filters accessible in other salt modules as simple functions? |
cachedout
approved these changes
Nov 8, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like this. Excellent idea.
Great! Probably needs a mention in the release notes as well. @max-arnold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is a port of Ansible
json_query
Jinja filter to make complex queries against json data structures. Query language http://jmespath.org/ parser depends onjmespath
python library (optional).It could be used to filter
pillar
data,yaml
maps, and in combination withhttp_query
. Can replace lots of ugly Jinja loops and in some cases help to avoid writing trivial custom modules https://docs.saltstack.com/en/latest/topics/tutorials/jinja_to_execution_module.htmlJinja template:
Rendered output:
Tests written?
Yes
Commits signed with GPG?
No
P.S. The feature is not intrusive, how about including it into the Fluorine branch?