Updated kafka returner to use confluent-kafka. #50579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The confluent-kafka-python package is a wrapper for the librdkafka C library. In benchmarks it delivers higher I/O and has the option for commercial support should you require it. https://github.com/confluentinc/confluent-kafka-python
cachedout
suggested changes
Nov 20, 2018
salt/returners/kafka_return.py
Outdated
| """ Called once for each message produced to indicate delivery result. | ||
| Triggered by poll() or flush(). """ | ||
| if err is not None: | ||
| print('Message delivery failed: {}'.format(err)) |
There was a problem hiding this comment.
We should not be printing right to standard out like this.
|
There are a number of lint errors here. Could you please fix them up? https://jenkinsci.saltstack.com/job/pr-lint/job/PR-50579/1/warnings52Result/new/file.202663858/ |
The refactoring was to make the code satisfy pylint.
cachedout
approved these changes
Nov 23, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The confluent-kafka-python package is a wrapper for the librdkafka C
library. In benchmarks it delivers higher I/O and has the option for
commercial support should you require it. I worked with the previous author @cedwards on this update.
https://github.com/confluentinc/confluent-kafka-python
What does this PR do?
Changes from the kafka-python library to the confluent-kafka-python library
Previous Behavior
Used the kafka-python library
New Behavior
Uses the confluent_kafka python library to return data in the same format as the previous returner.
Tests written?
No
Commits signed with GPG?
No