Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC - changing requisites/excludes #51183

Closed
wants to merge 2 commits into from

Conversation

waynew
Copy link
Contributor

@waynew waynew commented Jan 16, 2019

RFC text: https://github.com/waynew/salt/blob/rfc-changing-requisites/rfcs/0005-change-requisite-handling.md

There were some suggestions made on #6237 about how we should do requisites/excludes, but no actual decisions made.

I'm making this RFC so if we decide to not make code changes we have a place to point and say, "This is why."

Alternatively, if we decide it's something we want to change, well, there we go!

Signed-off-by: Wayne Werner <wwerner@saltstack.com>
@waynew waynew added the ZRETIRED - RFC retired label see SEP repo label Jan 16, 2019
@waynew waynew requested a review from a team as a code owner January 16, 2019 00:52
@thatch45
Copy link
Contributor

I think this is a really good idea, but I also think that we should make sure that this would be configurable. Part of the benefit of having excludes not remove requisites is that if you break something with an exclude then you would want to know about it.

Also, if you want this behavior today then the correct way to make the requisites would be to use requisite_ins from the states that might be excluded to that you are able to apply intent directionally

Signed-off-by: Wayne Werner <wwerner@saltstack.com>
@waynew
Copy link
Contributor Author

waynew commented Jan 17, 2019

@thatch45 I like making the new behavior opt-in. I've updated the RFC to specify that. I've got a couple of things to check/confirm. The biggest question I have right now, is --exclude-before-requisites too wordy for a command line argument? 😆

@thatch45
Copy link
Contributor

I think that argument would be fine :)

@s0undt3ch
Copy link
Collaborator

Both --ebr, --exclude-before-requisites for the same option?

@thatch45
Copy link
Contributor

Sounds resonable

@waynew
Copy link
Contributor Author

waynew commented Apr 9, 2019

Migrated to the SEP repo: saltstack/salt-enhancement-proposals#10

@waynew waynew closed this Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ZRETIRED - RFC retired label see SEP repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants