add support for directories and checking for free space #51385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@maxim-sermin The failing tests seem to be related to this change, can you look into them please? |
maxim-sermin
force-pushed
the
disk-enhancements
branch
from
b8c8fae to
67c1a40
Compare
|
@dwoz I fixed the tests |
dwoz
approved these changes
Feb 15, 2019
garethgreenaway
added a commit
to garethgreenaway/salt
that referenced
this pull request
Sep 19, 2019
dwoz
added a commit
that referenced
this pull request
Nov 14, 2019
[master] Porting #51385 to master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Expand the capabilities of the
diskstate.What issues does this PR fix or reference?
None
Previous Behavior
The
diskstate was previously only capable of evaluating disk mounts and one could only specify the amount of used space to verify.New Behavior
Now first the mounts are searched for the given
name(previous behavior) and if no match is found, a directory with the specifiednameis checked as a fallback.Additionally added the
freeparameter (which is false by default - backwards compatible) which treats theminimumandmaximumparameters as the range of unutilized space.Tests written?
Yes
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.