Virt info #52575
Closed
Virt info #52575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the salt.states.file.copy function to make the call to file.remove with the force parameter set to the same as one for salt.states.file.copy.
doc: Document glog matching in requisites
Volume infos fix
Add fat as a valid fs_type in parted module
Fix name of Python 2.7 development requirements file
bug: status might be a string, coerce it
Allow using salt modules in onlyif and unless
Allow to override git_pillar_base per-remote
Add cwd grain for working directory
Use __utils__ for registry commands
modules/postgres.py: replace sort
…module functions.
…aths in case the PATH is non-existent.
… trying to simulate the existence of a file and not whether its executable or not.
Provide access to `dns_plugin` `digitalocean`. Also, add `dns_plugin_propagation_seconds`.
Add an execution module that does primitive parsing on state and execution module fns.
…-plugin Add DigitalOcean DNS-01 verification to module.acme
…ttings beacons/network_settings.py: Wrong uses of variables
cron return a single line
…_support_saltenv Looks great! Thanks for the code!
…ndencies Looks great! Thanks!
Stops the Window installer from hanging
draft support for parsing slot results and appending text
Draft: support slot parsing inside dict and lists of dict or strings
…ot, get_on_crash, get_macs, get_devices and removed get_xml method
…ot, get_on_crash, get_macs, get_devices and removed get_xml method support slot parsing inside dict and lists of dict or strings only process strings handle not string objects change log level and add tests return text instead of ElementTree.element object for uuid fixing lints fixing lints readded get_xml function to virt module fixed indenetation for get_xml function fixed indenetation for get_xml function
|
@waheedi, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ryan-lane and @tkwilliams to be potential reviewers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It fixes few bugs with the current module and sticks to the standard way of implementing virt module functions, there were inconsistencies in the implementation of few functions like get_on_poweroff, get_on_crash, get_on_reboot, get_uuid and get_profiles and in their documentation too.
removed function get_xml as it does not belong here
What issues does this PR fix or reference?
#52431
Previous Behavior
salt '*' virt.vm_infoThe VM "<libvirt.virDomain object at 0x7f24e9e73198>" is not present
New Behavior
salt '*' virt.vm_infoTests written?
No (but tested)
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.