Add optional warnings to test.configurable_test_state #53959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
|
Hi @max-arnold this PR looks great! I'm just waiting to see whats up with the failing checks. Will get back soon on this. |
xeacott
approved these changes
Aug 1, 2019
max-arnold
force-pushed
the
configurable-test-state-warning
branch
from
c3dab2c to
415b280
Compare
max-arnold
force-pushed
the
configurable-test-state-warning
branch
from
415b280 to
aeeeab0
Compare
max-arnold
force-pushed
the
configurable-test-state-warning
branch
2 times, most recently
from
abe1081 to
3c9b1b7
Compare
max-arnold
force-pushed
the
configurable-test-state-warning
branch
2 times, most recently
from
765c03b to
fcd3099
Compare
max-arnold
force-pushed
the
configurable-test-state-warning
branch
from
fcd3099 to
e52b848
Compare
|
@Akm0d The only thing I forgot is to change the |
max-arnold
force-pushed
the
configurable-test-state-warning
branch
from
3367ade to
ec4fb4f
Compare
waynew
approved these changes
Dec 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add optional
warningsargument totest.configurable_test_state.The PR is backward-compatible, non-intrusive and involves a test module (shouldn't be very mission-critical). Please consider merging it into the oldest supported branch, so it won't be necessary to wait for another six months.
What issues does this PR fix or reference?
This is useful to inject warnings into a highstate process. Unlike the
salt.log.warningjinja function, the warnings are propagated back to a master.As per the mailing list request: https://groups.google.com/forum/#!topic/salt-users/4yrxKtNycsk
Tests written?
Yes
Commits signed with GPG?
No