Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ldap.managed errors #54342

Closed
wants to merge 1 commit into from
Closed

Conversation

sathieu
Copy link
Contributor

@sathieu sathieu commented Aug 29, 2019

What does this PR do?

Fixes a degression from 05e55bd (#48666):

  • AttributeError: 'tuple' object has no attribute 'encode'
  • ValueError: too many values to unpack

What issues does this PR fix or reference?

Fixes: #52022.

Tests written?

No

Commits signed with GPG?

No

Regression from 05e55bd (saltstack#48666):
- AttributeError: 'tuple' object has no attribute 'encode'
- ValueError: too many values to unpack

Fixes: saltstack#52022.
@sathieu sathieu requested a review from a team as a code owner August 29, 2019 10:40
@ghost ghost requested a review from Ch3LL August 29, 2019 10:40
@sathieu sathieu mentioned this pull request Aug 29, 2019
@dwoz
Copy link
Contributor

dwoz commented Dec 14, 2019

@sathieu This needs to be re-opened against the master branch. We are no longer accepting PRs to 2018.3. Sorry for the confusion.

@dwoz dwoz closed this Dec 14, 2019
@sathieu
Copy link
Contributor Author

sathieu commented Dec 15, 2019

Moved to #55651.

@sathieu sathieu deleted the ldap_managed_errors branch December 15, 2019 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants