Fix using password hashes with MariaDB

[pprkut]

MariaDB 10.2.0 introduced the 'ALTER USER' statement, but it did NOT remove the need to denote password hashes with the PASSWORD keyword.
Both CREATE USER as well as ALTER USER still need IDENTIFIED BY PASSWORD

This should be a more complete fix compared to previous attempts in #53861 and #54299

[jeffdyke]

just a note, this will have to be looked at in 2019.2 as the second part of the diff is actually:

qry = ("ALTER USER '" + user + "'@'" + host + "'"                                                              |~                                                                                                                             
                       " IDENTIFIED BY '" + password + "';")                                                                   |~                                                                                                                             
                args = {}

Not sure why args is not used, i'll take your version and apply it to the recent release, which is actually the one i'm trying to fix. But thanks for getting into 2018.3

[jeffdyke]

apparently i have to dig a bit deeper, I'm on release 2019.2.0 which does not seem to correspond to branch 2019.2 in the mysql.py module. In the release version it is still using user_chpass, but in the branch that has changed to _user_chpass_[mysql|mariadb] I'll have to bring this up elsewhere.

[jeffdyke]

if anyone is looking to patch the current release, there is a diff attached
that can be applied with (paths may vary) sudo patch /usr/lib/python2.7/dist-packages/salt/modules/mysql.py /home/{user}/mysql.patch

mysql.py.2019.2.patch.txt

[SMillerDev]

This should probably be rebuild since the build fails on:

13:12:15         13:11:26,209 [salt.minion                               :1676][ERROR   ] A command in 'pkg.info_installed' had a problem: package htop is not installed

Which doesn't really seem related to this change

[pprkut]

@garethgreenaway Any chance we could move this forward. Currently we have to create our own rpms because of this :-/

[dwoz]

@pprkut This needs to be re-opened against the master branch. We are no longer
accepting PRs to 2018.3. You can link back to this PR to perserver the
discussion. Sorry taking so long to get to this and for any confusion.