Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tencent Cloud 201921 #54526

Merged
merged 32 commits into from
Jan 9, 2020
Merged

Tencent Cloud 201921 #54526

merged 32 commits into from
Jan 9, 2020

Conversation

Akm0d
Copy link
Contributor

@Akm0d Akm0d commented Sep 18, 2019

What does this PR do?

Merge #54518 into 2019.2.1

doc/topics/cloud/tencentcloud.rst Outdated Show resolved Hide resolved
tests/unit/test_config.py Outdated Show resolved Hide resolved
tests/unit/test_config.py Outdated Show resolved Hide resolved
tests/unit/test_config.py Outdated Show resolved Hide resolved
tests/unit/test_config.py Outdated Show resolved Hide resolved
tests/unit/test_config.py Outdated Show resolved Hide resolved
tests/unit/test_config.py Outdated Show resolved Hide resolved
@Akm0d Akm0d requested a review from waynew September 20, 2019 16:44
@waynew waynew changed the title Tenentcloud 201921 Tencent Cloud 201921 Sep 24, 2019
tests/unit/test_config.py Show resolved Hide resolved
@Akm0d Akm0d changed the base branch from 2019.2.1 to master October 10, 2019 20:16
@likexian
Copy link
Contributor

Hello @Akm0d
Is there anything I can help?

@Akm0d
Copy link
Contributor Author

Akm0d commented Oct 18, 2019

@likexian we're just waiting for the unrelated test failures to pass or for approval from core

@Akm0d Akm0d requested a review from a team as a code owner October 22, 2019 20:24
@ghost ghost requested a review from cmcmarrow October 22, 2019 20:24
@Akm0d Akm0d force-pushed the tenentcloud_201921 branch from 7374e35 to 4ff06f4 Compare October 30, 2019 16:55
@likexian
Copy link
Contributor

likexian commented Nov 18, 2019

Hello,
The failed CI seems not the responsibility of this PR's code.
Can someone please have a review? it take too long to process.

@Akm0d
Copy link
Contributor Author

Akm0d commented Dec 2, 2019

10:48:08  /var/jenkins/workspace/pr-docs_PR-54526/doc/ref/clouds/all/salt.cloud.clouds.tencentcloud.rst:document isn't included in any toctree```

@Akm0d Akm0d force-pushed the tenentcloud_201921 branch from cee23ce to 7e0750d Compare December 11, 2019 21:38
@likexian
Copy link
Contributor

likexian commented Jan 2, 2020

@Akm0d This PR takes so long, what can I do for it?

@Akm0d
Copy link
Contributor Author

Akm0d commented Jan 4, 2020

@Akm0d This PR takes so long, what can I do for it?

I'm sorry this has taken so long :/ We just need all the tests passing.

@Akm0d Akm0d requested review from waynew and dwoz January 4, 2020 17:49
salt/cloud/clouds/tencentcloud.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jan 4, 2020

Codecov Report

Merging #54526 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #54526      +/-   ##
==========================================
+ Coverage   18.78%   18.78%   +0.01%     
==========================================
  Files         825      825              
  Lines      175895   175895              
  Branches    37838    37838              
==========================================
+ Hits        33028    33030       +2     
+ Misses     140192   140191       -1     
+ Partials     2675     2674       -1
Flag Coverage Δ
#archlts 18.06% <ø> (+0.01%) ⬆️
#centos7 23.73% <ø> (+0.01%) ⬆️
#proxy 23.76% <ø> (ø) ⬆️
#py2 18.58% <ø> (ø) ⬆️
#py3 18.41% <ø> (+0.01%) ⬆️
#runtests 18.78% <ø> (+0.01%) ⬆️
#ubuntu1604 23.7% <ø> (ø) ⬇️
#zeromq 18.78% <ø> (+0.01%) ⬆️
Impacted Files Coverage Δ
salt/transport/ipc.py 44.93% <0%> (-0.57%) ⬇️
salt/config/__init__.py 27.63% <0%> (+0.18%) ⬆️
salt/utils/event.py 38.67% <0%> (+0.31%) ⬆️

@codecov
Copy link

codecov bot commented Jan 4, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@8e529ca). Click here to learn what that means.
The diff coverage is 11.77%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #54526   +/-   ##
=========================================
  Coverage          ?   18.78%           
=========================================
  Files             ?      825           
  Lines             ?   175895           
  Branches          ?    37838           
=========================================
  Hits              ?    33030           
  Misses            ?   140191           
  Partials          ?     2674
Flag Coverage Δ
#archlts 18.06% <11.77%> (?)
#centos7 23.73% <0%> (?)
#proxy 23.76% <0%> (?)
#py2 18.58% <11.77%> (?)
#py3 18.41% <11.77%> (?)
#runtests 18.78% <11.77%> (?)
#ubuntu1604 23.7% <0%> (?)
#zeromq 18.78% <11.77%> (?)
Impacted Files Coverage Δ
salt/master.py 14.93% <ø> (ø)
salt/utils/win_functions.py 21.37% <0%> (ø)
salt/modules/systemd_service.py 15.11% <12.5%> (ø)

@Akm0d
Copy link
Contributor Author

Akm0d commented Jan 7, 2020

re-run full amazon1

@waynew
Copy link
Contributor

waynew commented Jan 7, 2020

FWIW, it seems like py2/amazon1 might be/have been pre-deprecated by Amazon.

@Akm0d Akm0d requested a review from dwoz January 7, 2020 19:23
@Akm0d
Copy link
Contributor Author

Akm0d commented Jan 8, 2020

re-run full amazon1

@likexian
Copy link
Contributor

likexian commented Jan 9, 2020

@Akm0d You are my hero!
It so difficult to make all tests pass. Thanks so much for your works.

@dwoz dwoz merged commit 8c0ccae into saltstack:master Jan 9, 2020
@Akm0d Akm0d deleted the tenentcloud_201921 branch January 9, 2020 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants