[master] Porting #52715 to master #54577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
garethgreenaway
changed the title
dwoz
approved these changes
Oct 28, 2019
s0undt3ch
suggested changes
Oct 28, 2019
dhiltonp
suggested changes
Oct 29, 2019
|
ping @garethgreenaway looks like you were the original committer of this PR. Can you take a look at the review comments? |
garethgreenaway
force-pushed
the
2019_2_1_port_52715
branch
from
8239e8c
to
44f871b
Compare
garethgreenaway
force-pushed
the
2019_2_1_port_52715
branch
from
44f871b
to
8914513
Compare
|
Looks like most of the changes for this are already on master, most likely from a merge forward from the 2018.3.x. branch. This will update the test with @s0undt3ch's requested changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting #52715 to master