Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[master] Porting #51344 to master #54595

Merged
merged 1 commit into from
Jan 2, 2020
Merged

[master] Porting #51344 to master #54595

merged 1 commit into from
Jan 2, 2020

Conversation

garethgreenaway
Copy link
Contributor

@garethgreenaway garethgreenaway commented Sep 19, 2019 •
edited
Loading

Porting #51344 to master

@garethgreenaway garethgreenaway requested a review from a team September 19, 2019 00:18
@ghost ghost requested review from dwoz and removed request for a team September 19, 2019 00:18
@garethgreenaway garethgreenaway changed the title [2019.2.1] Porting #51344 to 2019.2.1 [master] Porting #51344 to master Sep 24, 2019
@garethgreenaway garethgreenaway changed the base branch from 2019.2.1 to master September 24, 2019 22:49
Ch3LL
Ch3LL suggested changes Nov 22, 2019
View reviewed changes
doc/man/salt.7 Outdated Show resolved Hide resolved
@dwoz dwoz requested a review from a team as a code owner January 2, 2020 10:04
@codecov
Copy link

codecov bot commented Jan 2, 2020

Codecov Report

Merging #54595 into master will decrease coverage by 1.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #54595      +/-   ##
==========================================
- Coverage   18.84%   17.65%   -1.19%     
==========================================
  Files         823      612     -211     
  Lines      176080    99401   -76679     
  Branches    38040    22773   -15267     
==========================================
- Hits        33176    17547   -15629     
+ Misses     140179    79703   -60476     
+ Partials     2725     2151     -574
Flag Coverage Δ
#archlts ?
#centos7 ?
#proxy ?
#py2 ?
#py3 17.65% <ø> (-0.83%) ⬇️
#runtests ?
#ubuntu1604 ?
#windows2016 17.65% <ø> (?)
#zeromq 17.65% <ø> (-1.19%) ⬇️
Impacted Files Coverage Δ
salt/states/network.py 6.51% <ø> (ø)
salt/utils/__init__.py 20.45% <0%> (-79.55%) ⬇️
salt/utils/stringio.py 47.61% <0%> (-33.34%) ⬇️
salt/utils/vt_helper.py 0% <0%> (-26%) ⬇️
salt/utils/systemd.py 43.13% <0%> (-21.57%) ⬇️
salt/transport/client.py 41.86% <0%> (-12.98%) ⬇️
salt/utils/verify.py 16.44% <0%> (-10.71%) ⬇️
salt/utils/yamldumper.py 70.58% <0%> (-9.42%) ⬇️
salt/utils/nb_popen.py 19.46% <0%> (-8.06%) ⬇️
salt/utils/user.py 30.76% <0%> (-7.18%) ⬇️
... and 1191 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be5811e...1049e0e. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jan 2, 2020

Codecov Report

Merging #54595 into master will decrease coverage by 1.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #54595      +/-   ##
==========================================
- Coverage   18.84%   17.65%   -1.19%     
==========================================
  Files         823      612     -211     
  Lines      176080    99401   -76679     
  Branches    38040    22773   -15267     
==========================================
- Hits        33176    17547   -15629     
+ Misses     140179    79703   -60476     
+ Partials     2725     2151     -574
Flag Coverage Δ
#archlts ?
#centos7 ?
#proxy ?
#py2 ?
#py3 17.65% <ø> (-0.83%) ⬇️
#runtests ?
#ubuntu1604 ?
#windows2016 17.65% <ø> (?)
#zeromq 17.65% <ø> (-1.19%) ⬇️
Impacted Files Coverage Δ
salt/states/network.py 6.51% <ø> (ø)
salt/utils/__init__.py 20.45% <0%> (-79.55%) ⬇️
salt/utils/stringio.py 47.61% <0%> (-33.34%) ⬇️
salt/utils/vt_helper.py 0% <0%> (-26%) ⬇️
salt/utils/systemd.py 43.13% <0%> (-21.57%) ⬇️
salt/transport/client.py 41.86% <0%> (-12.98%) ⬇️
salt/utils/verify.py 16.44% <0%> (-10.71%) ⬇️
salt/utils/yamldumper.py 70.58% <0%> (-9.42%) ⬇️
salt/utils/nb_popen.py 19.46% <0%> (-8.06%) ⬇️
salt/utils/user.py 30.76% <0%> (-7.18%) ⬇️
... and 1191 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be5811e...1049e0e. Read the comment docs.

@waynew
Update network states doc
9acd41a 
Previously it was xmit_hash_policy, but that's not what the code is
actually looking for.
@waynew waynew force-pushed the 2019_2_1_port_51344 branch from 1049e0e to 9acd41a Compare January 2, 2020 17:48
@waynew
Copy link
Contributor

waynew commented Jan 2, 2020

@dwoz doc-only change here

@dwoz dwoz added the Documentation Relates to Salt documentation label Jan 2, 2020
@dwoz dwoz merged commit a09c953 into saltstack:master Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ch3LL Ch3LL Ch3LL requested changes

@dwoz dwoz Awaiting requested review from dwoz

Assignees

@Ch3LL Ch3LL

Labels
Documentation Relates to Salt documentation master-port
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@garethgreenaway @waynew @Ch3LL @dwoz