Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Backport 50541) btrfs: add all subvolume commands #54961

Merged
merged 5 commits into from
Dec 24, 2019
Merged

(Backport 50541) btrfs: add all subvolume commands #54961

merged 5 commits into from
Dec 24, 2019

Conversation

aplanas
Copy link
Contributor

@aplanas aplanas commented Oct 11, 2019

What does this PR do?

Add all subvolume commands to the btrfs module

Tests written?

Yes

(backport #50541, already merged in develop)

@dwoz dwoz requested a review from a team as a code owner November 26, 2019 01:12
@ghost ghost requested a review from DmitryKuzmenko November 26, 2019 01:12
dwoz
dwoz requested changes Dec 3, 2019
View reviewed changes
Copy link
Contributor

@dwoz dwoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aplanas Looks like some tests are failing on windows

aplanas and others added 4 commits December 3, 2019 17:01
@aplanas
btrfs: add all subvolume commands
1e885ff 
(cherry picked from commit c476a21)
@aplanas
btrfs: add subvolume_exists
9b28bb0 
(cherry picked from commit 5de7ce4)
@aplanas
btrfs: create and delete return False if noop
107218a 
If the create and delete actions are not needed, the function will
return False. This indicate that the submodule was already there,
or was missing on the first place.

(cherry picked from commit 5feae48)
@aplanas
test_btrfs: skip test_subvolume_create on Windows
0a2efa8
@aplanas aplanas requested a review from dwoz December 4, 2019 08:29
@dwoz dwoz merged commit bc01113 into saltstack:master Dec 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwoz dwoz dwoz approved these changes

@DmitryKuzmenko DmitryKuzmenko Awaiting requested review from DmitryKuzmenko

Assignees

@dwoz dwoz

Labels
master-port
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aplanas @dwoz @garethgreenaway