[develop, neon] fix(cron.py): ensure get_entry includes the special entries as well

[myii]

What does this PR do?

CC: @mchugh19.

Follow-up to #52441, which was introduced due to a PR in SaltStack Formulas: saltstack-formulas/cron-formula#4.

While working through that cron-formula PR, found that special entries are not included by get_entry.

So the formula creates the following crontab for root:

# Lines below here are managed by Salt, do not edit
# comment1 SALT_CRON_IDENTIFIER:task1
0 0 7 1 6 echo test > /tmp/test
# comment4 SALT_CRON_IDENTIFIER:task4
*/5 * * * * echo task4 > /tmp/test4
# comment3 SALT_CRON_IDENTIFIER:task3
@hourly echo task3 > /tmp/test3

task3 isn't being found with the current version of cron.get_entry:

$ sudo salt-call --config-dir=/tmp/kitchen/etc/salt cron.get_entry root task3
local:
    False

Found only task1 and task4 accessible by get_entry:

[
    {
        "minute": "0",
        "hour": "0",
        "daymonth": "7",
        "month": "1",
        "dayweek": "6",
        "identifier": "task1",
        "cmd": "echo test > /tmp/test",
        "comment": "comment1",
        "commented": false
    },
    {
        "minute": "*/5",
        "hour": "*",
        "daymonth": "*",
        "month": "*",
        "dayweek": "*",
        "identifier": "task4",
        "cmd": "echo task4 > /tmp/test4",
        "comment": "comment4",
        "commented": false
    }
]

list_tab(user) contains it under the special key:

{
    "pre": [],
    "crons": [
        {
            "minute": "0",
            "hour": "0",
            "daymonth": "7",
            "month": "1",
            "dayweek": "6",
            "identifier": "task1",
            "cmd": "echo test > /tmp/test",
            "comment": "comment1",
            "commented": false
        },
        {
            "minute": "*/5",
            "hour": "*",
            "daymonth": "*",
            "month": "*",
            "dayweek": "*",
            "identifier": "task4",
            "cmd": "echo task4 > /tmp/test4",
            "comment": "comment4",
            "commented": false
        }
    ],
    "special": [
        {
            "spec": "@hourly",
            "cmd": "echo task3 > /tmp/test3",
            "identifier": "task3",
            "comment": "comment3",
            "commented": false
        }
    ],
    "env": []
}

So after applying the fix:

$ sudo salt-call --config-dir=/tmp/kitchen/etc/salt cron.get_entry root task3
[
    {
        "minute": "0",
        "hour": "0",
        "daymonth": "7",
        "month": "1",
        "dayweek": "6",
        "identifier": "task1",
        "cmd": "echo test > /tmp/test",
        "comment": "comment1",
        "commented": false
    },
    {
        "minute": "*/5",
        "hour": "*",
        "daymonth": "*",
        "month": "*",
        "dayweek": "*",
        "identifier": "task4",
        "cmd": "echo task4 > /tmp/test4",
        "comment": "comment4",
        "commented": false
    },
    {
        "spec": "@hourly",
        "cmd": "echo task3 > /tmp/test3",
        "identifier": "task3",
        "comment": "comment3",
        "commented": false
    }
]
local:
    ----------
    cmd:
        echo task3 > /tmp/test3
    comment:
        comment3
    commented:
        False
    identifier:
        task3
    spec:
        @hourly

The saltcheck tests using this fixed version of cron.py are all working as expected:

• https://travis-ci.org/myii/cron-formula/builds/598399086

What issues does this PR fix or reference?

Tests written?

No

Commits signed with GPG?

Yes

[myii]

Note, this depends on the merge of #52441 into master.

[mchugh19]

Referenced Neon PR has master port waiting in #54985

[bryceml]

Please re-open this to master, see https://github.com/saltstack/salt-enhancement-proposals/blob/master/accepted/0014-dev-overhaul.md

[myii]

@bryceml Sure, this is based on #54985 (which is #52441 being ported to master), so as soon as that's done, I'll rebase this accordingly.

[dwoz]

@myii I'm closing this since we're no longer accepting PRs to develop and you will port it after #54985 is merged.