Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[master] Port #51047 (Jinja map troubleshooting) #55253

Merged
merged 3 commits into from
Dec 19, 2019
Merged

[master] Port #51047 (Jinja map troubleshooting) #55253

merged 3 commits into from
Dec 19, 2019

Conversation

max-arnold
Copy link
Contributor

Master backport of #51047 (execution module for troubleshooting Jinja map files)

@max-arnold max-arnold requested a review from a team as a code owner November 11, 2019 12:32
@ghost ghost requested a review from xeacott November 11, 2019 12:32
@dwoz dwoz added has master-port port to master has been created master-port and removed has master-port port to master has been created labels Nov 12, 2019
@dwoz dwoz added the Needs-Testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases label Dec 3, 2019
@max-arnold max-arnold force-pushed the jinja-maps branch 8 times, most recently from 86465d2 to 7a382af Compare December 17, 2019 03:35
@codecov
Copy link

codecov bot commented Dec 17, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@6d83704). Click here to learn what that means.
The diff coverage is 68.19%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #55253   +/-   ##
=========================================
  Coverage          ?   18.78%           
=========================================
  Files             ?      818           
  Lines             ?   175160           
  Branches          ?    37573           
=========================================
  Hits              ?    32894           
  Misses            ?   139669           
  Partials          ?     2597
Flag Coverage Δ
#archlts 17.72% <68.19%> (?)
#centos7 18.77% <68.19%> (?)
#proxy 18.79% <68.19%> (?)
#py2 18.59% <68.19%> (?)
#py3 18.44% <68.19%> (?)
#runtests 18.81% <68.19%> (?)
#ubuntu1604 23.7% <ø> (?)
#zeromq 18.81% <68.19%> (?)
Impacted Files Coverage Δ
salt/modules/jinja.py 68.19% <68.19%> (ø)

1 similar comment
@codecov
Copy link

codecov bot commented Dec 17, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@6d83704). Click here to learn what that means.
The diff coverage is 68.19%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #55253   +/-   ##
=========================================
  Coverage          ?   18.78%           
=========================================
  Files             ?      818           
  Lines             ?   175160           
  Branches          ?    37573           
=========================================
  Hits              ?    32894           
  Misses            ?   139669           
  Partials          ?     2597
Flag Coverage Δ
#archlts 17.72% <68.19%> (?)
#centos7 18.77% <68.19%> (?)
#proxy 18.79% <68.19%> (?)
#py2 18.59% <68.19%> (?)
#py3 18.44% <68.19%> (?)
#runtests 18.81% <68.19%> (?)
#ubuntu1604 23.7% <ø> (?)
#zeromq 18.81% <68.19%> (?)
Impacted Files Coverage Δ
salt/modules/jinja.py 68.19% <68.19%> (ø)

@max-arnold
Copy link
Contributor Author

max-arnold commented Dec 17, 2019 •
edited
Loading

@dwoz I added a couple of tests and mentioned the feature in release notes. Could you please review the PR again?

@max-arnold max-arnold mentioned this pull request Dec 17, 2019
Closed
@max-arnold
Copy link
Contributor Author

re-run macosxmojave-py3
re-run opensuse15-py2
re-run opensuse15-py3

@max-arnold
Copy link
Contributor Author

re-run full debian8-py2
re-run full windows2019-py3

@dwoz dwoz merged commit 25b127f into saltstack:master Dec 19, 2019
@max-arnold max-arnold mentioned this pull request Jan 22, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akm0d Akm0d Akm0d approved these changes

@xeacott xeacott Awaiting requested review from xeacott

Assignees
No one assigned
Labels
master-port Needs-Testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@max-arnold @Akm0d @dwoz @garethgreenaway