Initial logging Refactoring Bugfix #55441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```
20:25:21,233 [tests.integration :170 ][ERROR ][MainProcess(3708)] An exception occurred in the salt logging process: unsupported format string passed to NoneType.__format__
Traceback (most recent call last):
File "C:\\Users\\ADMINI~1\\AppData\\Local\\Temp\\kitchen\\testing\tests\integration\__init__.py", line 161, in start_log_forwarding_consumer
record = logging.makeLogRecord(record_dict)
File "C:\Python35\Lib\logging\__init__.py", line 368, in makeLogRecord
rv = _logRecordFactory(None, None, "", 0, "", (), None, None)
File "C:\\Users\\ADMINI~1\\AppData\\Local\\Temp\\kitchen\\testing\salt\_logging\impl.py", line 125, in __init__
self.bracketname = '[{:<17}]'.format(self.name)
TypeError: unsupported format string passed to NoneType.__format__
```
ghost
requested a review
from 
Akm0d
reviewed
Nov 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
See title.