(Backport 52962) mount: add not_change parameter to set_fstab and similars #55516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 12ae2db)
The current 'set_' family search the entry based on a 'match_on' parameter. If the line is found check that there is no difference between the expectations and the present line. If there are changes this line gets replaced. This default behaviour is the correct one in cases where the Salt code owns all the changes made on entries. But in some scenarios we do not want to overwrite the line if is already present, even if there are diferences in other parameters, like the option field. This patch add a new parameter, 'not_change', that if is True will not overwrite the present line in any case. Also update the `mount` state to transfer this new parameter. (cherry picked from commit 5e748e7)
ghost
requested a review
from 
dwoz
approved these changes
Dec 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The current 'set_' family search the entry based on a 'match_on'
parameter. If the line is found check that there is no difference
between the expectations and the present line. If there are changes
this line gets replaced.
This default behavior is the correct one in cases where the Salt
code owns all the changes made on entries. But in some scenarios
we do not want to overwrite the line if is already present, even
if there are differences in other parameters, like the option field.
This patch add a new parameter, 'not_change', that if is True will
not overwrite the present line in any case.
Also update the mount state to transfer this new parameter.
Tests written?
Yes
(backport #52962, already merged in develop, on top of #54965)