Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microoptimize the command to set FreeBSD's virtual grain #55739

Merged
merged 2 commits into from
Dec 28, 2019

Conversation

asomers
Copy link
Contributor

@asomers asomers commented Dec 27, 2019

What does this PR do?

Slightly microoptimizes the code that sets the virtual grain on FreeBSD

What issues does this PR fix or reference?

none

Tests written?

No. Not a new feature.

Commits signed with GPG?

Yes

@asomers asomers requested a review from a team as a code owner December 27, 2019 02:32
@ghost ghost requested a review from twangboy December 27, 2019 02:32
@dwoz
Copy link
Contributor

dwoz commented Dec 27, 2019

@asomers Does the _virtual method have any unit tests? If not, please add some.

@dwoz dwoz merged commit 4e862c4 into saltstack:master Dec 28, 2019
@asomers asomers deleted the sysctl_n branch July 27, 2022 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants