New recursive diff master #55759
Merged
New recursive diff master #55759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… iterable recursively. Also added unittests.
This will make it more compatible with the existing dictdiffer. Also added tests for the new parameter.
Updated and added unittests to match.
Also remove FilterFalseyTestCase class as this is part of another PR
Remove is_iterable as it is already implemented in is_iter; Replaced all elif after return with if; Remove else after return or continue; Added function docstrings where they were missing.
ghost
requested a review
from 
dwoz
approved these changes
Jan 4, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port to master of #53715
What does this PR do?
It adds
recursive_difftosalt.utils.data. This is a recursive diff that can handle mixed nested mappings/iterables. This is an alternative tosalt/utils/dictdiffer.pyorsalt/utils/listdiffer.pythat can only handle nested dicts and list-of-nested-dicts respectively.What issues does this PR fix or reference?
None that I'm aware of.
Previous Behavior
Only nested dicts or list-of-nested-dicts could be recursively diffed. Nothing is available to recursively diff a mix of lists, dicts, OrderedDicts, sets, tuples or other mapping or iterable type.
New Behavior
salt.utils.data.recursive_diffis able to produce a dict witholdandnewkeys for any combination of nested mapping- or iterable types. Some options are only applicable to certain types, likeignore_keysandignore_missing_keyswill only work on (nested) mappings, andignore_orderwill only make a difference on ordered datatypes (like OrderedDict and list).Tests written?
Yes
Commits signed with GPG?
Yes