Avoid warning noise in logrotate.get #56105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
dwoz
added
has-failing-test
Needs-Testcase
garethgreenaway
removed
Needs-Testcase
garethgreenaway
previously approved these changes
Jan 14, 2021
There is no guarantee that a lookup failure is necessarily a problem, so presenting a message to this effect as a warning has led to confusion for some (and annoyance for others). This resolves the issue by showing the message at the debug level. Fixes saltstack#53988
Ch3LL
force-pushed
the
fix-logrotate-noise
branch
from
a367ebb to
0903ebd
Compare
garethgreenaway
approved these changes
Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
There is no guarantee that a lookup failure is necessarily a problem, so presenting a message to this effect as a warning has led to confusion for some (and annoyance for others). This resolves the issue
by showing the message at the debug level.
What issues does this PR fix or reference?
Fixes #53988
Previous Behavior
(full details in the issue linked above)
I have a number of users use Salt to provision their VMs with Vagrant, and most of them have asked me at one point if these warnings mean that provisioning is failing and if they should abort and re-do it.
New Behavior
We should have beautiful silence (except when running with the
-l debugargument).Tests written?
No
Commits signed with GPG?
Yes