-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Don't remove one directory level from slspath" #56341
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That change should absolutely not be reverted. It was a bugfix. From the documentation:
"the path to the current SLS file". Not a directory. |
Those docs should be fixed, not breaking everyone's states |
thatch45
approved these changes
Mar 10, 2020
Actually, after looking at the code, I think that we should revert, but not without making other changes. See here for my reasoning on this. |
twangboy
approved these changes
Mar 10, 2020
DmitryKuzmenko
approved these changes
Mar 11, 2020
Ch3LL
approved these changes
Mar 11, 2020
agraul
added a commit
to agraul/salt-1
that referenced
this pull request
Apr 27, 2020
This was a breaking change in v3000 that was fixed in 3000.1 Fixes bsc#1170104
agraul
added a commit
to openSUSE/salt
that referenced
this pull request
Apr 30, 2020
Backport from 3000.1 - Revert changes to slspath (saltstack/salt#56341)
meaksh
pushed a commit
to openSUSE/salt
that referenced
this pull request
May 7, 2020
This was a breaking change in v3000 that was fixed in 3000.1 Fixes bsc#1170104
meaksh
added a commit
to openSUSE/salt-packaging
that referenced
this pull request
May 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 7c28995.
This change is being reverted because it broke states without going through any kind of deprecation path.
What issues does this PR fix or reference?
#56119
Tests written?
Yes
Commits signed with GPG?
Yes