Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port #51088 to master #56965

Merged
merged 12 commits into from
Dec 5, 2022
Merged

Port #51088 to master #56965

merged 12 commits into from
Dec 5, 2022

Conversation

alexey-zhukovin
Copy link
Contributor

What does this PR do?

Port #51088 to master

@alexey-zhukovin alexey-zhukovin added Needs-Testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases master-port labels Apr 29, 2020
@alexey-zhukovin alexey-zhukovin requested a review from a team as a code owner April 29, 2020 11:21
@ghost ghost requested review from twangboy and removed request for a team April 29, 2020 11:21
@waynew waynew force-pushed the master-port-51088 branch from 42a71ac to 88f6643 Compare March 16, 2021 21:09
@waynew waynew removed the Needs-Testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases label Mar 16, 2021
@waynew
Copy link
Contributor

waynew commented Mar 18, 2021

re-run macosxmojave

@waynew
Copy link
Contributor

waynew commented Mar 23, 2021

re-run freebsd122-py3

waynew and others added 7 commits October 24, 2022 10:33
@waynew @twangboy
Add test nqn being None
11b43eb
@waynew @twangboy
Test when nqn is provided successfully
7dc373b 
When we have an NVMe qualified name, then we should actually be
setting the value on the host.
@waynew @twangboy
Test when NQN fails to be set
8b61cdf 
If we can't set the NVMe Qualified Name, then we need to halt creation
and delete the host, since it was not correctly created.
@waynew @twangboy
Test host_update when nqn is empty
c1576a0 
If NVMe Qualified Name is not provided, we should not try to attach it to the
host.
@waynew @twangboy
Test nqn successfully provided
c2cc937 
If we can provide a correct NQN then it should be set on the host, and
result should be True.
@waynew @twangboy
Test failing NQN on host_update should be False
489e613 
When updating a host if adding a NVMe device fails then we should
simply return False. No rollbacks required.
@sdodsley @twangboy
Update purefa module to support NVMeF NQN for host connectivity
b4bc22d
twangboy
twangboy previously approved these changes Oct 24, 2022
View reviewed changes
twangboy
twangboy previously approved these changes Oct 24, 2022
View reviewed changes
@Ch3LL Ch3LL added the Sulfur v3006.0 release code name and version label Nov 3, 2022
waynew
waynew approved these changes Dec 5, 2022
View reviewed changes
Copy link
Contributor

@waynew waynew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure I wrote the tests for this, FWIW, but also LGTM 👍

@Ch3LL Ch3LL merged commit 01899be into saltstack:master Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garethgreenaway garethgreenaway garethgreenaway approved these changes

@waynew waynew waynew approved these changes

@twangboy twangboy twangboy left review comments

Assignees
No one assigned
Labels
master-port Sulfur v3006.0 release code name and version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@alexey-zhukovin @waynew @garethgreenaway @twangboy @dwoz @Ch3LL @sdodsley