-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added an idem exec and state module #57969
Conversation
If I understand this correctly, idem is asynchronous, right? How this would work with the planned Tornado upgrade where it is only possible to have a single event loop per thread? |
This is executed in a separate process that is isolated from the original tornado loop |
Does idem start this process somewhere, or it is a minion worker process? (I'm mostly asking this to educate myself, feel free to ignore) |
Can Salt run states and/or execution modules in the main thread that has an existing event loop? |
Since this is an execution module it will run inside of a worker process. Idem will run using the available loop that should be present when the worker is spun up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a question about the context manager usage.
I'd really like to do a deeper dive here (and maybe get some of the other more experienced team to review as well). Maybe we could review during your Twitch stream on Monday? That way you could walk us through the changes, your thoughts, any questions that you had as you were putting this together, and maybe we'd come up with questions as well. Or it will all make perfect sense and everyone will be on board 😂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This now has conflicts
What does this PR do?
fixes #57980
depends #57993
Adds an exec module and a state module for idem.
Idem execution modules and states can now be run through salt in a non-obtrusive way
Merge requirements satisfied?
Commits signed with GPG?
Yes